Skip to content

Performance-oriented server refactoring#2105

Merged
ctiller merged 10 commits intogrpc:masterfrom
vjpai:poller2
Jun 19, 2015
Merged

Performance-oriented server refactoring#2105
ctiller merged 10 commits intogrpc:masterfrom
vjpai:poller2

Conversation

@vjpai
Copy link
Copy Markdown
Contributor

@vjpai vjpai commented Jun 17, 2015

  1. Remove completion queue creation from under the C++ lock
  2. Split the C server lock into two: one for global (e.g. channel) state, and one for per-call state

@googlebot
Copy link
Copy Markdown

googlebot commented Jun 17, 2015

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@ctiller
Copy link
Copy Markdown
Member

ctiller commented Jun 17, 2015

This change requires #1577 to be merged first.

@vjpai
Copy link
Copy Markdown
Contributor Author

vjpai commented Jun 17, 2015

Depends on #1577 . @ctiller - can you make the CLA-bot happy?

@ctiller ctiller self-assigned this Jun 18, 2015
@vjpai
Copy link
Copy Markdown
Contributor Author

vjpai commented Jun 18, 2015

Relates to issue #2017.

@vjpai
Copy link
Copy Markdown
Contributor Author

vjpai commented Jun 19, 2015

The only failures now refer to gcov filling up. I'll wait for it to go green before asking for detailed reviews, but I've removed the DNM. Of course, it should still wait on #1577.

@vjpai
Copy link
Copy Markdown
Contributor Author

vjpai commented Jun 19, 2015

And yes, we're green now!

@vjpai vjpai mentioned this pull request Jun 19, 2015
Merged
@ctiller
Copy link
Copy Markdown
Member

ctiller commented Jun 19, 2015

Didn't I mention LGTM already? I know I thought it :)

On Fri, Jun 19, 2015, 9:20 AM Vijay Pai notifications@github.com wrote:

And yes, we're green now!

—
Reply to this email directly or view it on GitHub
#2105 (comment).

@vjpai
Copy link
Copy Markdown
Contributor Author

vjpai commented Jun 19, 2015

ok, let me do a manual merge and push again, and then I'll let you know what's up

@googlebot
Copy link
Copy Markdown

googlebot commented Jun 19, 2015

CLAs look good, thanks!

ctiller added a commit that referenced this pull request Jun 19, 2015
@ctiller
Merge pull request #2105 from vjpai/poller2
8deffe9 
Performance-oriented server refactoring
@ctiller ctiller merged commit 8deffe9 into grpc:master Jun 19, 2015
@vjpai vjpai mentioned this pull request Jul 9, 2015
Closed
@vjpai vjpai deleted the poller2 branch July 15, 2015 21:24
@lock lock bot locked as resolved and limited conversation to collaborators Jan 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@ctiller ctiller

Labels

area/concurrency area/core area/performance cla: yes lang/c++ lang/core

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vjpai @googlebot @ctiller