Skip to content

include string_util.h for the prototype of gpr_strdup and fix a typo.#2057

Merged
ctiller merged 1 commit intogrpc:masterfrom
kfsone:master
Jun 15, 2015
Merged

include string_util.h for the prototype of gpr_strdup and fix a typo.#2057
ctiller merged 1 commit intogrpc:masterfrom
kfsone:master

Conversation

@kfsone
Copy link
Copy Markdown
Contributor

@kfsone kfsone commented Jun 15, 2015

Fixes two warnings in log_win32.c under msvc2015
log_win32.c(109): warning C4013: 'gpr_strdup' undefined; assuming extern returning int
log_win32.c(109): warning C4047: 'return': 'char *' differs in levels of indirection from 'int'

and corrects a typo in an error message

@kfsone
include string_util.h for the prototype of gpr_strdup and typo.
be2a75c 
Fixes two warnings in log_win32.c under msvc2015
log_win32.c(109): warning C4013: 'gpr_strdup' undefined; assuming extern returning int
log_win32.c(109): warning C4047: 'return': 'char *' differs in levels of indirection from 'int'

and corrects a typo in an error message
@googlebot
Copy link
Copy Markdown

googlebot commented Jun 15, 2015

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@kfsone
Copy link
Copy Markdown
Contributor Author

kfsone commented Jun 15, 2015

On 6/14/2015 9:18 PM, googlebot wrote:

Thanks for your pull request. It looks like this may be your first
contribution to a Google open source project, in which case you'll
need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. |I signed it!|) and we'll
verify. Thanks.

—
Reply to this email directly or view it on GitHub
#2057 (comment).

I signed it

@googlebot
Copy link
Copy Markdown

googlebot commented Jun 15, 2015

CLAs look good, thanks!

ctiller added a commit that referenced this pull request Jun 15, 2015
@ctiller
Merge pull request #2057 from kfsone/master
f61af65 
include string_util.h for the prototype of gpr_strdup and fix a typo.
@ctiller ctiller merged commit f61af65 into grpc:master Jun 15, 2015
@lock lock bot locked as resolved and limited conversation to collaborators Jan 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kfsone @googlebot @ctiller