Stability fixes for python_plugin_test#2040
Merged
tbetbetbe merged 1 commit intogrpc:masterfrom Jun 11, 2015
Merged
Conversation
The "normal" timeout is eliminated. The "short" timeout is changed to be the length used in tests that will time out as part of their execution and the "long" timeout is changed to be a ridiculously high value that will have no bearing on passing tests. The "pause" behavior of _ServicerMethods is changed to use a threading.Condition's wait/notify methods rather than busy-sleeping. Tests that used servicer delay to verify that asynchronous calls are not affected by server delay are changed to use servicer pause to verify that asynchronous calls return while the servicer is paused. Busy-sleeping in testHalfDuplexCallWedged is replaced with use of a threading.Condition's wait/notify methods. Fixes grpc#1900.
tbetbetbe
added a commit
that referenced
this pull request
Jun 11, 2015
Stability fixes for python_plugin_test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "normal" timeout is eliminated. The "short" timeout is changed to
be the length used in tests that will time out as part of their
execution and the "long" timeout is changed to be a ridiculously high
value that will have no bearing on passing tests.
The "pause" behavior of _ServicerMethods is changed to use a
threading.Condition's wait/notify methods rather than busy-sleeping.
Tests that used servicer delay to verify that asynchronous calls are
not affected by server delay are changed to use servicer pause to
verify that asynchronous calls return while the servicer is paused.
Busy-sleeping in testHalfDuplexCallWedged is replaced with use of a
threading.Condition's wait/notify methods.
Fixes #1900.