Revamp of C# channel options (aka channel args)#1995
Merged
tbetbetbe merged 3 commits intogrpc:masterfrom Jun 11, 2015
Merged
Conversation
This was referenced Jun 9, 2015
fd6c256 to
6d53a5c
Compare
This was referenced Jun 9, 2015
Contributor
Author
|
Travis issues don't seem to be related to this PR. Posted issues for them. |
Contributor
Author
|
I rebased this one so it's mergeable. Please take a look. I believe the travis failures are not connected to this change at all. |
tbetbetbe
added a commit
that referenced
this pull request
Jun 11, 2015
Revamp of C# channel options (aka channel args)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to be merged after #1992 is in.
Changes:
-- Use more understandable name "ChannelOptions" instead of cryptic "ChannelArgs".
-- Get rid of the builder pattern when building channel options and allow user to just specify a list of ChannelOption objects (that should be more idiomatic for C# and allows using object initializer).
-- Provide constants for well-known channel options.
-- Allow server to use ChannelOptions as well.
-- Add some tests.