Stop using native callbacks for C##1966
Merged
murgatroid99 merged 2 commits intogrpc:masterfrom Jun 9, 2015
Merged
Conversation
murgatroid99
added a commit
that referenced
this pull request
Jun 9, 2015
Stop using native callbacks for C#
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reworks the way completion events are handled in C#.
Initially, calling completion_queue_next was invoking a native-to-managed callback. That worked but it had some unexpected performance overhead (especially under mono). Also it required some extra code to make sure that the delegates won't get deallocated before the native callback gets called (which would result in a crash).
The new approach utilizes the simplified layout of gprc_event and after completion_queue_next returns callback handler is retrieved from a concurrent dictionary. This should also simplify testing in the future because it is now easier to mock callback registry in tests.