Update QPS test to proto3#1958
Merged
dgquintas merged 5 commits intogrpc:masterfrom Jun 9, 2015
vjpai:qps-proto3
Merged
Conversation
Contributor
Author
regularly. Also, convert qps_test to test, from benchmark
Contributor
Author
|
Removed the DNM. Please take a look. |
Contributor
Author
|
Putting the DNM back on. |
…n' into qps-proto3 Conflicts: test/cpp/qps/qps_test_openloop.cc
Contributor
Author
|
Removed the DNM since #1984 went in. Please review. Thanks! |
Contributor
Author
|
... and it's green! |
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch to proto3 syntax
Fixes #1677
Do not merge until after completing PR #1948