Conversation
lidizheng
reviewed
Feb 27, 2019
Contributor
lidizheng
left a comment
There was a problem hiding this comment.
Do you think we should ignore this rule altogether in .pylintrc?
| return self._traceback | ||
|
|
||
| def add_callback(self, callback): | ||
| del callback |
Contributor
Author
There was a problem hiding this comment.
ericgribkoff
approved these changes
Feb 27, 2019
lidizheng
approved these changes
Feb 27, 2019
apolcyn
added a commit
to apolcyn/grpc
that referenced
this pull request
Mar 5, 2019
apolcyn
added a commit
that referenced
this pull request
Mar 5, 2019
Fix pylint on 1.19.x - backport #18190
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #18189. An updated transitive linter dependency has recently made our linter more strict. The main new finding is that a couple of our classes have 8 ancestors, where it believes 7 is the magic number.
There are three approaches to this problem:
Option 3 is a non-starter. I opted for option 1 because we're not tacitly granting approval; we're recognizing that this is a problem