Support "darwin_x86_64" CPU in cares.BUILD.#18125
Merged
nicolasnoble merged 1 commit intogrpc:masterfrom Feb 21, 2019
Merged
Conversation
Bazel recognizes both "darwin" and "darwin_x86_64" as CPU values, and the Apple Bazel rules currently recommend the latter for building macOS targets. Until this is cleaned up, this change allows grpc to build correctly when that configuration is used. Fixes grpc#17649.
|
Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement. After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.
Regards, |
Contributor
Author
|
I've signed the CLA. |
apolcyn
approved these changes
Feb 21, 2019
Contributor
Author
|
Thanks for the quick approval! Now that the checks have passed, is there anything else needed before you can merge this? |
nicolasnoble
approved these changes
Feb 21, 2019
chokobole
added a commit
to chokobole/felicia
that referenced
this pull request
Mar 12, 2019
On macos, due to grpc can't be built with `--cpu darwin_x86_64`, libgtest.a was built on `darwin` and `darwin_x86_64`, because `objc_library`'s the default value of cpu is `local`, which is `darwin_x86_64` and this depends on `gtest`. Now grpc/grpc#18125 was accepted, and we upgraded grpc version to v1.9.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bazel recognizes both "darwin" and "darwin_x86_64" as CPU values, and
the Apple Bazel rules currently recommend the latter for building
macOS targets. Until this is cleaned up, this change allows grpc to
build correctly when that configuration is used.
Fixes #17649.