Conversation
|
Just saw the same error with code that doesn't include this change, so it's probably unrelated. Created a separate issue #1734 for this. |
|
Just checked the python travis failure and it looks like this is not a known flake. |
|
Yeah I need to check that |
|
Otherwise looks good. |
|
Wow. (_c_test timed out.) |
|
Restarted the Python test. Trying to reproduce here. |
|
This will need more investigation (Tuesday latest). |
|
Renamed. |
Update Python for core server shutdown change
|
@nicolasnoble - it's probably safe to start this review @jtattermusch - can you re-integrate C# changes? |
|
Aye aye. On Thu, Jun 11, 2015 at 4:28 PM, Craig Tiller notifications@github.com
|
There was a problem hiding this comment.
have an exit label here maybe and use goto from everywhere else instead of duplicating the exit logic ?
There was a problem hiding this comment.
It's worthwhile. There are further changes in #1577, and I want someone to do a thorough rewrite of this module entirely soon to eliminate any event related allocations - so maybe leave it til then?
|
Aside from that nit, I didn't spot anything out of whack, and that globally is LGTM. |
|
@soltanmm @jtattermusch - we'll likely need to work together a little today to resolve conflicts. |
Fix upstream merge conflicts
+ all tests pass, - but there are a couple of workarounds - tests are flaky
Initial progress on ruby shutdown api migration
temporary hotfix before backup poller removal is done
|
VERT! |
Fixes #1753
Fixes #988