Skip to content

C Core API cleanup.#1472

Merged
yang-g merged 37 commits intogrpc:masterfrom
ctiller:bye-bye-completion-queue-pie
May 13, 2015
Merged

C Core API cleanup.#1472
yang-g merged 37 commits intogrpc:masterfrom
ctiller:bye-bye-completion-queue-pie

Conversation

@ctiller
Copy link
Copy Markdown
Member

@ctiller ctiller commented May 4, 2015

Simplify grpc_event into something that can be non-heap allocated.
Deprecate grpc_event_finish.
Remove grpc_op_error - use an int as this is more idiomatic C style.

ctiller added 3 commits May 4, 2015 14:53
@ctiller
C Core API cleanup.
64be9f7 
Simplify grpc_event into something that can be non-heap allocated.
Deprecate grpc_event_finish.
Remove grpc_op_error - use an int as this is more idiomatic C style.
@ctiller
Fix memory leak
745d63a
@ctiller
Bump version
85b5e8b
@ctiller ctiller added the lang/C# label May 4, 2015
@murgatroid99
Copy link
Copy Markdown
Member

murgatroid99 commented May 4, 2015

The changes to Node and PHP look good to me.

@ctiller
Copy link
Copy Markdown
Member Author

ctiller commented May 4, 2015

@nathanielmanistaatgoogle, @soltanmm - PTAL at Python code here
@murgatroid99, @jcanizales - Could someone send me a pull request against this for Objective C
@jtattermusch - I got a little bit done for C#, but then my build environment failed - can you send me a pull request against this for the rest?
@tbetbetbe - I haven't touched Ruby due to some install issues on my machine - can you (or somebody) send a pull request against this for it?

@ctiller
Copy link
Copy Markdown
Member Author

ctiller commented May 4, 2015

@yang-g - PTAL at the C++ code

@yang-g
Copy link
Copy Markdown
Contributor

yang-g commented May 4, 2015

LGTM

@nathanielmanistaatgoogle
Copy link
Copy Markdown
Contributor

nathanielmanistaatgoogle commented May 5, 2015

LGTM but @soltanmm is actively working on the affected Python code and will conduct a more thorough review.

@jcanizales
Copy link
Copy Markdown
Contributor

jcanizales commented May 11, 2015

Re the Objective-C change: let's add ".DS_Store" files to the gitignore.

@ctiller
Copy link
Copy Markdown
Member Author

ctiller commented May 11, 2015

Can someone send me a PR against this one to do this?

On Mon, May 11, 2015 at 10:50 AM Jorge Canizales notifications@github.com
wrote:

Re the Objective-C change: let's add ".DS_Store" files to the gitignore.

—
Reply to this email directly or view it on GitHub
#1472 (comment).

@murgatroid99
Copy link
Copy Markdown
Member

murgatroid99 commented May 11, 2015

I can do that

@soltanmm soltanmm mentioned this pull request May 12, 2015
Merged
@ctiller
Copy link
Copy Markdown
Member Author

ctiller commented May 13, 2015

@tbetbetbe - can you look over the Ruby changes
@yang-g - can you look over the rest

@ctiller
Copy link
Copy Markdown
Member Author

ctiller commented May 13, 2015

(also: Green)

@ctiller ctiller removed the disposition/help wanted Maintainers do not have enough resources to allocate to this at the moment. Help is appreciated! label May 13, 2015
@ctiller
Copy link
Copy Markdown
Member Author

ctiller commented May 13, 2015

Fixes #1576

yang-g added a commit that referenced this pull request May 13, 2015
@yang-g
Merge pull request #1472 from ctiller/bye-bye-completion-queue-pie
0fff02c 
C Core API cleanup.
@yang-g yang-g merged commit 0fff02c into grpc:master May 13, 2015
@lock lock bot locked as resolved and limited conversation to collaborators Jan 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@yang-g yang-g

Labels

area/api/BREAKAGE area/core cla: yes kind/internal cleanup lang/all wrapped languages lang/c++ lang/C# lang/node lang/ObjC lang/php lang/Python lang/ruby priority/P0/RELEASE BLOCKER

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@ctiller @murgatroid99 @yang-g @nathanielmanistaatgoogle @soltanmm @jcanizales @googlebot @jtattermusch