Skip to content

Use clang-format-3.5#104

Merged
nicolasnoble merged 2 commits intogrpc:masterfrom
ctiller:clangfmt
Jan 19, 2015
Merged

Use clang-format-3.5#104
nicolasnoble merged 2 commits intogrpc:masterfrom
ctiller:clangfmt

Conversation

@ctiller
Copy link
Copy Markdown
Member

@ctiller ctiller commented Jan 18, 2015

No description provided.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe test if $CLANG_FORMAT is executable ?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@ctiller
Copy link
Copy Markdown
Member Author

ctiller commented Jan 19, 2015

Fixes #84.

nicolasnoble added a commit that referenced this pull request Jan 19, 2015
@nicolasnoble nicolasnoble merged commit dd2a35d into grpc:master Jan 19, 2015
@dklempner
Copy link
Copy Markdown
Contributor

I see a bunch of:

YAML:12:35: error: invalid boolean
AllowShortFunctionsOnASingleLine: All

Error reading /usr/local/google/grpc/grpc/.clang-format: Invalid argument
Can't find usable .clang-format, using LLVM style

@yang-g
Copy link
Copy Markdown
Contributor

yang-g commented Jan 21, 2015

I see various errors too.
One is it does not recognize All in line 12, setting it to true seems to
fix it.
Then there a many places of unrecognized keys. Most of them I checked
should be correct according to clang format 3.5 docs
http://llvm.org/releases/3.5.0/tools/clang/docs/ClangFormatStyleOptions.html
.

I am now pretty sure I did something wrong but do not know what :)

On Tue, Jan 20, 2015 at 6:13 PM, David Klempner notifications@github.com
wrote:

I see a bunch of:

YAML:12:35: error: invalid boolean
AllowShortFunctionsOnASingleLine: All

Error reading /usr/local/google/grpc/grpc/.clang-format: Invalid argument
Can't find usable .clang-format, using LLVM style


Reply to this email directly or view it on GitHub
#104 (comment).

@ctiller
Copy link
Copy Markdown
Member Author

ctiller commented Jan 21, 2015

What command are you guys running to do this?

On Tue, Jan 20, 2015, 23:46 Yang Gao notifications@github.com wrote:

I see various errors too.
One is it does not recognize All in line 12, setting it to true seems to
fix it.
Then there a many places of unrecognized keys. Most of them I checked
should be correct according to clang format 3.5 docs

http://llvm.org/releases/3.5.0/tools/clang/docs/ClangFormatStyleOptions.html
.

I am now pretty sure I did something wrong but do not know what :)

On Tue, Jan 20, 2015 at 6:13 PM, David Klempner notifications@github.com

wrote:

I see a bunch of:

YAML:12:35: error: invalid boolean
AllowShortFunctionsOnASingleLine: All

Error reading /usr/local/google/grpc/grpc/.clang-format: Invalid
argument
Can't find usable .clang-format, using LLVM style


Reply to this email directly or view it on GitHub
#104 (comment).


Reply to this email directly or view it on GitHub
#104 (comment).

@yang-g
Copy link
Copy Markdown
Contributor

yang-g commented Jan 21, 2015

I tried both our script in tools/clang-format/ and clang-format-3.5. My
clang-format-3.5 seems to be a correct link to something under llvm3.5 and
my repo was synced before I tried.

On Wed, Jan 21, 2015 at 8:18 AM, Craig Tiller notifications@github.com
wrote:

What command are you guys running to do this?

On Tue, Jan 20, 2015, 23:46 Yang Gao notifications@github.com wrote:

I see various errors too.
One is it does not recognize All in line 12, setting it to true seems to
fix it.
Then there a many places of unrecognized keys. Most of them I checked
should be correct according to clang format 3.5 docs

http://llvm.org/releases/3.5.0/tools/clang/docs/ClangFormatStyleOptions.html
.

I am now pretty sure I did something wrong but do not know what :)

On Tue, Jan 20, 2015 at 6:13 PM, David Klempner <
notifications@github.com>

wrote:

I see a bunch of:

YAML:12:35: error: invalid boolean
AllowShortFunctionsOnASingleLine: All

Error reading /usr/local/google/grpc/grpc/.clang-format: Invalid
argument
Can't find usable .clang-format, using LLVM style


Reply to this email directly or view it on GitHub
#104 (comment).


Reply to this email directly or view it on GitHub
#104 (comment).


Reply to this email directly or view it on GitHub
#104 (comment).

@ctiller ctiller deleted the clangfmt branch January 26, 2015 06:29
lalo pushed a commit to lalo/grpc that referenced this pull request Oct 19, 2017
Fix extra ref count on blob to PyBytes conversion
@lock lock bot locked as resolved and limited conversation to collaborators Feb 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants