test: migrate tests to use GROVE_PROXY as admin#22
Merged
kevinlichan merged 5 commits intodevfrom Aug 5, 2025
Merged
Conversation
* feat: use grove-address-registry in MainnetController * refactor: use avalanche instead of base in the grove test base
|
Coverage after merging migrate-tests into dev will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
kevinlichan
approved these changes
Aug 4, 2025
kevinlichan
left a comment
There was a problem hiding this comment.
Approved. These changes to updated the the test suite from Spark contracts to Grove contracts and updating to the grove-address-registry looks in good form to me.
barrutko
added a commit
that referenced
this pull request
Aug 11, 2025
* feat: reintroduce Centrifuge controller updates; remove Superstate integration (#21) * feat: add Centrifuge to ForeignController * Revert "feat: bring back superstate & maple; remove centrifuge crosschain transfers (#16)" This reverts commit 71fd906. * refactor: add minor refactorings * feat: extract Lib, bring back Maple * fix: remove unused import * chore: remove irrelevant change * refactor: reorder * fix: remove redundant imports * test: migrate tests to use GROVE_PROXY as admin (#22) * chore: update address registry * refactor: rename folders * test: start grove mainnet fork tests * test: migrate tests to use GROVE_PROXY * feat: use grove-address-registry in MainnetController (#23) * feat: use grove-address-registry in MainnetController * refactor: use avalanche instead of base in the grove test base * fix: minor issues (#25) * fix: correct error message * fix: use explicit imports * fix: remove unused import * refactor: merge ICentrifugeToken and ICentrifugeV3VaultLike interfaces (#28) * feat: add centrifuge recipient to scripts (#30) * feat: add centrifuge recipient to foreign controller init * feat: add centrifuge mint recipients to mainnet init * feat: hardcode remoteExtraGasLimit to 0 (#27) * feat: deploy updated controllers (#31)
barrutko
added a commit
that referenced
this pull request
Aug 22, 2025
* feat: add v1.6.0 changes (#32) * feat: reintroduce Centrifuge controller updates; remove Superstate integration (#21) * feat: add Centrifuge to ForeignController * Revert "feat: bring back superstate & maple; remove centrifuge crosschain transfers (#16)" This reverts commit 71fd906. * refactor: add minor refactorings * feat: extract Lib, bring back Maple * fix: remove unused import * chore: remove irrelevant change * refactor: reorder * fix: remove redundant imports * test: migrate tests to use GROVE_PROXY as admin (#22) * chore: update address registry * refactor: rename folders * test: start grove mainnet fork tests * test: migrate tests to use GROVE_PROXY * feat: use grove-address-registry in MainnetController (#23) * feat: use grove-address-registry in MainnetController * refactor: use avalanche instead of base in the grove test base * fix: minor issues (#25) * fix: correct error message * fix: use explicit imports * fix: remove unused import * refactor: merge ICentrifugeToken and ICentrifugeV3VaultLike interfaces (#28) * feat: add centrifuge recipient to scripts (#30) * feat: add centrifuge recipient to foreign controller init * feat: add centrifuge mint recipients to mainnet init * feat: hardcode remoteExtraGasLimit to 0 (#27) * feat: deploy updated controllers (#31) * feat: add v1.6.0 Cantina audit (#33) * feat: add v1.6.0 ChainSecurity audit (#34)
barrutko
added a commit
that referenced
this pull request
Oct 10, 2025
* chore: sync audits (#35) * feat: add v1.6.0 changes (#32) * feat: reintroduce Centrifuge controller updates; remove Superstate integration (#21) * feat: add Centrifuge to ForeignController * Revert "feat: bring back superstate & maple; remove centrifuge crosschain transfers (#16)" This reverts commit 71fd906. * refactor: add minor refactorings * feat: extract Lib, bring back Maple * fix: remove unused import * chore: remove irrelevant change * refactor: reorder * fix: remove redundant imports * test: migrate tests to use GROVE_PROXY as admin (#22) * chore: update address registry * refactor: rename folders * test: start grove mainnet fork tests * test: migrate tests to use GROVE_PROXY * feat: use grove-address-registry in MainnetController (#23) * feat: use grove-address-registry in MainnetController * refactor: use avalanche instead of base in the grove test base * fix: minor issues (#25) * fix: correct error message * fix: use explicit imports * fix: remove unused import * refactor: merge ICentrifugeToken and ICentrifugeV3VaultLike interfaces (#28) * feat: add centrifuge recipient to scripts (#30) * feat: add centrifuge recipient to foreign controller init * feat: add centrifuge mint recipients to mainnet init * feat: hardcode remoteExtraGasLimit to 0 (#27) * feat: deploy updated controllers (#31) * feat: add v1.6.0 Cantina audit (#33) * feat: add v1.6.0 ChainSecurity audit (#34) * feat: add Pendle PT redemptions (#36) * wip * wip * wip * test: add redeemPendlePT tests * cleanup * cleanup * remove maple * remove keywords to reduce size * cleanup * feat: add minAmountOut param to pendle redemption (#37)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in the PR
Folders renamed:
avalanche-forktogrove-avalanche-forksince tests use Grove addressesbase-forktospark-base-forksince tests use Spark addressesmainnet-forktospark-mainnet-forksince tests use Spark addressesNew test folder introduced:
grove-mainnet-fork- a folder with mainnet fork tests, using Grove addresses.grove-mainnet-fork/ForkTestBase.t.solis almost an exact copy ofspark-mainnet-fork/ForkTestBase.t.sol. The only differences are:Multiple test files moved from
spark-mainnet-forktogrove-mainnet-fork. In order to make them compatible with the new test base,SPARK_PROXYreference was replaced withGROVE_PROXYreferencespark-address-registryimport inMainnetController.solwas swapped togrove-address-registry