Skip to content

added annex figures, tables, equations#738

Closed
de-code wants to merge 1 commit into
grobidOrg:masterfrom
elifesciences:back-section-figure-tables-upstream
Closed

added annex figures, tables, equations#738
de-code wants to merge 1 commit into
grobidOrg:masterfrom
elifesciences:back-section-figure-tables-upstream

Conversation

@de-code

@de-code de-code commented Apr 14, 2021

Copy link
Copy Markdown
Collaborator

resolves #737

@de-code de-code requested review from kermitt2 and lfoppiano April 14, 2021 13:40
@de-code de-code self-assigned this Apr 14, 2021
@coveralls

coveralls commented Apr 14, 2021

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.006%) to 38.943% when pulling 6f45c06 on elifesciences:back-section-figure-tables-upstream into 4073084 on kermitt2:master.

@de-code de-code force-pushed the back-section-figure-tables-upstream branch from 3605866 to 6f45c06 Compare April 14, 2021 13:53
@de-code

de-code commented Apr 14, 2021

Copy link
Copy Markdown
Collaborator Author

I am not quite sure how I managed to increase the coverage without adding tests or deleting code.

@kermitt2 kermitt2 added the bug From Hemiptera and especially its suborder Heteroptera label Apr 14, 2021
@lfoppiano

Copy link
Copy Markdown
Member

With the standard model, I cannot see any difference, the "Extended Data Figure 1" is not extracted at all in both cases.
I've checked the code and the PR looks good to me.

@de-code

de-code commented May 13, 2021

Copy link
Copy Markdown
Collaborator Author

I noticed one issue with it, is that the figure ids are reset. e.g. first body figure has the id fig_0. Then the first back section / annex figure also has the id fig_0.

@lfoppiano

Copy link
Copy Markdown
Member

I close this, which is continued on #1215

@lfoppiano lfoppiano closed this Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug From Hemiptera and especially its suborder Heteroptera

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Figures and tables in the back / annex section ignored

4 participants