Process figures,tables and equations from back/annex section#1215
Merged
lfoppiano merged 16 commits intoSep 5, 2025
Conversation
minor intendation issue
…com/elifesciences/grobid into elifesciences-back-section-figure-tables-upstream
…pstream # Conflicts: # grobid-core/src/main/java/org/grobid/core/engines/FullTextParser.java
…pstream # Conflicts: # grobid-core/src/main/java/org/grobid/core/data/Figure.java # grobid-core/src/main/java/org/grobid/core/document/TEIFormatter.java # grobid-core/src/main/java/org/grobid/core/engines/FullTextParser.java
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR extends the processing of figures, tables, and equations to the back/annex section of documents, which previously only processed them in the main body text. The changes also fix table/figure identifier numbering by maintaining sequential IDs across document sections.
- Adds figure, table, and equation processing to the annex section using existing processing methods
- Refactors code to use consistent variable naming and extract reusable methods
- Implements sequential ID assignment for figures and tables across body and annex sections
Reviewed Changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| GrobidRestProcessFiles.java | Removes unused imports |
| FullTextParser.java | Main processing logic changes to handle annex figures/tables/equations and improve code organization |
| TEIFormatter.java | Updates toTEIAnnex method signature to accept figures, tables, and equations parameters |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| @@ -2257,158 +2319,163 @@ private static boolean testClosingTag(StringBuilder buffer, | |||
| * Process figures identified by the full text model | |||
| */ | |||
| protected List<Figure> processFigures(String rese, List<LayoutToken> layoutTokens) { | |||
| return processFigures(rese, layoutTokens,0); | |||
There was a problem hiding this comment.
Magic number 0 should be replaced with a named constant for the default start figure ID.
| String rese, | ||
| List<LayoutToken> tokenizations, | ||
| Document doc) { | ||
| return processTables(rese, tokenizations, doc, 0); |
There was a problem hiding this comment.
Magic number 0 should be replaced with a named constant for the default start table ID.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
continue of Pull #738 without conflicts. Also aiming to fix the table/figures identifiers as discussed in #738 (comment)