Skip to content

Update jquery to version > 3.5.0 to avoid XSS + bibtex fix#1028

Merged
kermitt2 merged 3 commits intomasterfrom
bugfix/update-jquery
Jun 12, 2023
Merged

Update jquery to version > 3.5.0 to avoid XSS + bibtex fix#1028
kermitt2 merged 3 commits intomasterfrom
bugfix/update-jquery

Conversation

@lfoppiano
Copy link
Copy Markdown
Member

@lfoppiano lfoppiano commented Jun 8, 2023

This should solve #1023 and #1027

@lfoppiano lfoppiano added the bug From Hemiptera and especially its suborder Heteroptera label Jun 8, 2023
@lfoppiano lfoppiano changed the title Update jquery to version > 3.5.0 to avoid XSS Update jquery to version > 3.5.0 to avoid XSS + bibtex fix Jun 8, 2023
@kermitt2
Copy link
Copy Markdown
Collaborator

Thanks a lot ! It should fix #1027 yes, we'll see for the next docker build.

@kermitt2 kermitt2 merged commit 94af135 into master Jun 12, 2023
@lfoppiano lfoppiano deleted the bugfix/update-jquery branch June 12, 2023 21:48
@lfoppiano
Copy link
Copy Markdown
Member Author

I've created a new branch 0.7.3-fixes and cherry-picked these changes there.
I think we can build the 0.7.3 docker image again and replace the old one.

@lfoppiano
Copy link
Copy Markdown
Member Author

Both the CRF and the CRF for ARM docker images are updated.
In the HF space, in the embedded version the bibtex is still returned.. There is something related to the HF stuff that is changing the request from xml to text I think.

@kermitt2
Copy link
Copy Markdown
Collaborator

In the HF space, in the embedded version the bibtex is still returned.. There is something related to the HF stuff that is changing the request from xml to text I think.

With slightly older docker image, it was working, for example https://huggingface.co/spaces/kermitt2/grobid-crf running with 0.7.3.-SNAPSHOT is correctly managing XML for processHeader. I was rather suspecting something with the JDK version (more or less the only thing that changed between the images), but weird in any cases.

Screenshot from 2023-06-13 08-42-41

@lfoppiano
Copy link
Copy Markdown
Member Author

Sorry, good news.. it's working.. It seems that I did not properly refresh..

image

@kermitt2
Copy link
Copy Markdown
Collaborator

Cool ! I'll update the full image too.

@kermitt2
Copy link
Copy Markdown
Collaborator

It's done for the full image on Docker Hub too, and it works fine on HF.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug From Hemiptera and especially its suborder Heteroptera

Projects

None yet

2 participants