Skip to content

fix(ui): allow self frame-src for pdf doc mode#901

Merged
imnotjames merged 1 commit into
developfrom
fix/897/pdf-frame-src
Apr 26, 2026
Merged

fix(ui): allow self frame-src for pdf doc mode#901
imnotjames merged 1 commit into
developfrom
fix/897/pdf-frame-src

Conversation

@imnotjames

@imnotjames imnotjames commented Apr 26, 2026

Copy link
Copy Markdown
Contributor

Description

The content security policy inadvertently prevents the PDF doc mode from operating. This loosens the frame-src to allow this feature to operate.

Linked Issue: Fixes #897

Changes

  • Adds self to CSP frame-src

Summary by CodeRabbit

  • Chores
    • Updated security configuration to permit same-origin embedded content.

@coderabbitai

coderabbitai Bot commented Apr 26, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 77ef09d3-abb3-4257-be64-cb91e026f3fa

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • ✅ Review completed - (🔄 Check again to review again)
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/897/pdf-frame-src
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch fix/897/pdf-frame-src

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot requested review from balazs-szucs and zachyale April 26, 2026 08:41
@imnotjames imnotjames marked this pull request as ready for review April 26, 2026 15:34
@imnotjames imnotjames merged commit ed35da2 into develop Apr 26, 2026
17 checks passed
@imnotjames imnotjames deleted the fix/897/pdf-frame-src branch April 26, 2026 17:11
paulbovbel pushed a commit to paulbovbel/grimmory that referenced this pull request Apr 27, 2026
dsmouse pushed a commit to dsmouse/grimmory that referenced this pull request May 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PDF Doc-mode Viewer does not load

2 participants