backend/src/main/java/org/booklore/app/service/AppBookService.java (1)

58-58: LGTM — behavior-preserving constant extraction.

The raw Specification[] declaration mirrors the pre-existing new Specification[0] pattern, so no new unchecked-warning surface is introduced. As a purely stylistic optional nit, you could declare it as Specification<?>[] to be slightly more precise, but it doesn't change the generated code or the call sites.

Also applies to: 1055-1055, 1122-1122

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@backend/src/main/java/org/booklore/app/service/AppBookService.java` at line
58, Replace the raw Specification[] type of the constant
EMPTY_SPECIFICATION_ARRAY with the more precise generic form Specification<?>[]
(update the declaration of EMPTY_SPECIFICATION_ARRAY in AppBookService and the
same occurrences at the other two locations referenced) so the constant
expresses its wildcard element type without changing runtime behavior.

backend/src/main/java/org/booklore/config/security/SecurityConfig.java (1)

50-50: LGTM — safe and targeted.

No change to authorization semantics; only the empty-array allocation site is swapped. Out of scope for this PR, but since unauthenticatedEndpoints is built from COMMON_UNAUTHENTICATED_ENDPOINTS and never mutated in opdsBasicAuthSecurityChain, a future cleanup could pass COMMON_UNAUTHENTICATED_ENDPOINTS directly to requestMatchers(...) and drop the ArrayList/toArray round-trip entirely.

Also applies to: 89-89

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@backend/src/main/java/org/booklore/config/security/SecurityConfig.java` at
line 50, Replace the dynamic construction of unauthenticatedEndpoints and the
toArray call with a direct use of the static array: where
opdsBasicAuthSecurityChain builds an ArrayList from
COMMON_UNAUTHENTICATED_ENDPOINTS and calls
requestMatchers(unauthenticatedEndpoints.toArray(EMPTY_STRING_ARRAY)), change it
to call requestMatchers(COMMON_UNAUTHENTICATED_ENDPOINTS) directly and remove
the temporary ArrayList and EMPTY_STRING_ARRAY constant since
COMMON_UNAUTHENTICATED_ENDPOINTS is never mutated.

backend/src/main/java/org/booklore/app/service/AppSeriesService.java (1)

36-36: LGTM — consistent with the AppBookService change.

Same pattern as AppBookService.EMPTY_SPECIFICATION_ARRAY; behavior is preserved. Since this constant is duplicated across AppBookService and AppSeriesService (and a Predicate[] variant exists in AppBookSpecification and BookRuleEvaluatorService), an optional follow-up would be to centralize them in a small EmptyArrays utility class to enforce single-source-of-truth — but that's purely cosmetic.

Also applies to: 377-377

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@backend/src/main/java/org/booklore/app/service/AppSeriesService.java` at line
36, Duplicate empty-array constants exist
(AppSeriesService.EMPTY_SPECIFICATION_ARRAY and
AppBookService.EMPTY_SPECIFICATION_ARRAY, plus Predicate[] variants in
AppBookSpecification and BookRuleEvaluatorService); to centralize, create a
small utility class (e.g., EmptyArrays) exposing typed constants
(Specification<?>[] EMPTY_SPECIFICATION_ARRAY, Predicate<?>[]
EMPTY_PREDICATE_ARRAY), replace usages in AppSeriesService, AppBookService,
AppBookSpecification and BookRuleEvaluatorService to reference EmptyArrays, and
remove the now-redundant local constants so all code uses the single source of
truth.