Skip to content

fix(ui): drop hard coded author/cover image upload limits#782

Merged
balazs-szucs merged 1 commit into
grimmory-tools:developfrom
imnotjames:fix/781/drop-frontend-upload-limiter
Apr 24, 2026
Merged

fix(ui): drop hard coded author/cover image upload limits#782
balazs-szucs merged 1 commit into
grimmory-tools:developfrom
imnotjames:fix/781/drop-frontend-upload-limiter

Conversation

@imnotjames

@imnotjames imnotjames commented Apr 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

drops the hard coded image upload limits from the UI. this pushes the upload limit to the backend, which is part of migrating the cover upload size limit to the predefined file upload limit in server settings

Linked Issue: Fixes #781

Changes

Summary by CodeRabbit

  • Bug Fixes
    • Removed file size restrictions on cover photo uploads in the author editor and book metadata editor, enabling larger files to be uploaded without client-side limitations.

@coderabbitai

coderabbitai Bot commented Apr 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

Removes client-side file size validation constraints from three file upload components across two HTML templates, allowing uploads without enforcing the previously specified 5,000,000-byte maximum file sizes.

Changes

Cohort / File(s) Summary
File Upload Size Limits
frontend/src/app/features/author-browser/components/author-editor/author-editor.component.html, frontend/src/app/features/metadata/component/book-metadata-center/metadata-editor/metadata-editor.component.html		 Removed maxFileSize attribute (5,000,000 bytes) from three file upload components: cover photo in author editor and ebook/audiobook covers in metadata editor, eliminating client-side file size validation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

frontend, enhancement

Poem

🐰 No limits now, just sky so high,
The files can soar, oh my oh my!
Five million bytes? That's now no more,
Our uploads dance across the floor! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The PR title follows conventional commit format with 'fix' prefix and clearly describes the main change of removing hardcoded upload limits from UI.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The PR description adequately explains what changes are being made and why, including the migration context.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
✨ Simplify code
  • Create PR with simplified code

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@obviouslyallie obviouslyallie linked an issue Apr 23, 2026 that may be closed by this pull request
Covers have unexpected size limits #781
Closed
2 tasks
@imnotjames imnotjames marked this pull request as ready for review April 24, 2026 03:20
@imnotjames imnotjames force-pushed the fix/781/drop-frontend-upload-limiter branch from 0afd09a to acd29e3 Compare April 24, 2026 03:20
balazs-szucs
balazs-szucs approved these changes Apr 24, 2026
View reviewed changes

@balazs-szucs balazs-szucs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

@balazs-szucs balazs-szucs merged commit cb3e4af into grimmory-tools:develop Apr 24, 2026
17 checks passed
github-merge-queue Bot pushed a commit that referenced this pull request Apr 25, 2026
@imnotjames
fix(ui): drop hard coded author/cover image upload limits (#782)
4bcbf8a
dsmouse pushed a commit to dsmouse/grimmory that referenced this pull request May 11, 2026
@imnotjames
fix(ui): drop hard coded author/cover image upload limits (grimmory-t…
9edb6b3 
…ools#782)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@balazs-szucs balazs-szucs balazs-szucs approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement frontend

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Covers have unexpected size limits

2 participants

@imnotjames @balazs-szucs