Skip to content

fix(release): always publish nightly images on manual runs#571

Merged
zachyale merged 1 commit into
developfrom
fix/always-publish-nightly-images-on-manual-run
Apr 18, 2026
Merged

fix(release): always publish nightly images on manual runs#571
zachyale merged 1 commit into
developfrom
fix/always-publish-nightly-images-on-manual-run

Conversation

@zachyale

@zachyale zachyale commented Apr 18, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Description

Remove the manual nightly smoke-test path that skipped image publishing.

Nightly runs should now behave consistently regardless of how they are triggered: both scheduled and manually dispatched runs will build, publish, and notify using the same flow

Changes

  • remove the publish_image workflow dispatch input from the nightly workflow
  • make Build and Push Nightly Image run for all nightly executions, including manual runs
  • require a successful nightly image publish before sending the Discord notification
  • remove the remaining workflow logic that supported the old “notes only” nightly path

Summary by CodeRabbit

Chores

  • Streamlined nightly publish workflow: Removed manual publish toggle feature to simplify scheduled execution paths.
  • Refined publish notifications: Discord alerts now require successful completion of both note generation and image build stages before dispatching.

@zachyale zachyale merged commit bc49a0f into develop Apr 18, 2026
7 of 8 checks passed
@zachyale zachyale deleted the fix/always-publish-nightly-images-on-manual-run branch April 18, 2026 00:59
@coderabbitai

coderabbitai Bot commented Apr 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9d86238c-1bb4-43ea-839a-254d7aaa86ad

📥 Commits

Reviewing files that changed from the base of the PR and between e9bcd83 and ed90a29.

📒 Files selected for processing (1)
  • .github/workflows/publish-nightly.yml
📝 Walkthrough

Walkthrough

Removed the publish_image input from the nightly publish workflow's manual dispatch trigger and its associated conditional logic. The build-and-push job now executes only based on job graph constraints rather than manual gates. Updated Discord notification conditions to require both generate-notes and build-and-push success.

Changes

Cohort / File(s) Summary
Workflow Configuration
.github/workflows/publish-nightly.yml		 Removed publish_image boolean input from workflow_dispatch. Removed conditional gating on build-and-push job tied to manual input. Simplified notify-discord condition to exclude handling for skipped build-and-push results.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

chore

Poem

🐰 A workflow streamlined, oh what delight!
No more manual gates blocking the night,
Removed the input, simplified the flow,
Discord notifies when jobs succeed, you know!
Cleaner and faster, hopping just right! 🎯

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/always-publish-nightly-images-on-manual-run
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch fix/always-publish-nightly-images-on-manual-run

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot added the chore label Apr 18, 2026
zachyale added a commit that referenced this pull request Apr 22, 2026
@zachyale
fix(release): always publish nightly images on manual runs (#571)
c6d567e
This was referenced Apr 22, 2026
Closed
Merged
Merged
@coderabbitai coderabbitai Bot mentioned this pull request May 1, 2026
Merged
dsmouse pushed a commit to dsmouse/grimmory that referenced this pull request May 11, 2026
@zachyale
fix(release): always publish nightly images on manual runs (grimmory-…
9908d0f 
…tools#571)
@coderabbitai coderabbitai Bot mentioned this pull request May 14, 2026
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

chore

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@zachyale