Skip to content

chore(api): drop unused code in AmazonBookParser and AudibleParser#368

Merged
balazs-szucs merged 1 commit into
grimmory-tools:developfrom
imnotjames:chore/-/drop-unused-amazon-method
Apr 4, 2026
Merged

chore(api): drop unused code in AmazonBookParser and AudibleParser#368
balazs-szucs merged 1 commit into
grimmory-tools:developfrom
imnotjames:chore/-/drop-unused-amazon-method

Conversation

@imnotjames

@imnotjames imnotjames commented Apr 4, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Description

drops unused methods

Related to #366

Changes

  • drops AmazonBookParser.extractSearchPreviews
  • drops AudibleParser.extractSearchPreviews and methods only used by that method.

Summary by CodeRabbit

  • Refactor
    • Optimized book metadata extraction from Amazon and Audible sources through streamlined internal processes, consolidating lookup workflows for improved efficiency.

@imnotjames imnotjames marked this pull request as ready for review April 4, 2026 03:12
@coderabbitai

coderabbitai Bot commented Apr 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

This PR removes private search-preview extraction methods from two parser classes. AmazonBookParser removes extractSearchPreviews() logic, and AudibleParser removes DOM extraction helpers. The control flow now delegates to alternative metadata retrieval mechanisms instead.

Changes

Cohort / File(s) Summary
Search Preview Method Removals
booklore-api/src/main/java/org/booklore/service/metadata/parser/AmazonBookParser.java, booklore-api/src/main/java/org/booklore/service/metadata/parser/AudibleParser.java		 Removed private methods that previously extracted preview metadata from search results. Amazon parser no longer builds previews from search DOM; Audible parser removes DOM traversal helpers. Total 146 lines removed across both files.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Suggested labels

backend, chore

Suggested reviewers

  • balazs-szucs

Poem

🐰 With a hop and a bound, old code takes flight,
Private methods vanish, the codebase feels light,
Search previews fade like morning dew,
Cleaner paths emerge, refreshed and new! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The PR title follows conventional commit format with type 'chore', scope 'api', and a clear description of the changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The pull request description adequately covers the purpose and changes, matching the required template structure with description and changes sections.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
✨ Simplify code
  • Create PR with simplified code

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot requested a review from balazs-szucs April 4, 2026 03:13
balazs-szucs
balazs-szucs approved these changes Apr 4, 2026
View reviewed changes

@balazs-szucs balazs-szucs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@balazs-szucs balazs-szucs merged commit 2337933 into grimmory-tools:develop Apr 4, 2026
15 checks passed
@coderabbitai coderabbitai Bot mentioned this pull request Apr 4, 2026
Merged
zachyale pushed a commit to zachyale/grimmory that referenced this pull request Apr 17, 2026
@imnotjames @zachyale
chore(api): drop unused code in AmazonBookParser and AudibleParser (g…
c3ab4d0 
…rimmory-tools#368)
zachyale pushed a commit to zachyale/grimmory that referenced this pull request Apr 17, 2026
@imnotjames @zachyale
chore(api): drop unused code in AmazonBookParser and AudibleParser (g…
6aa7f8e 
…rimmory-tools#368)
zachyale pushed a commit that referenced this pull request Apr 17, 2026
@imnotjames @zachyale
chore(api): drop unused code in AmazonBookParser and AudibleParser (#368
2c11074 
)
zachyale pushed a commit that referenced this pull request Apr 22, 2026
@imnotjames @zachyale
chore(api): drop unused code in AmazonBookParser and AudibleParser (#368
b05d76d 
)
@coderabbitai coderabbitai Bot mentioned this pull request May 4, 2026
Merged
7 tasks
dsmouse pushed a commit to dsmouse/grimmory that referenced this pull request May 11, 2026
@imnotjames
chore(api): drop unused code in AmazonBookParser and AudibleParser (g…
39a2910 
…rimmory-tools#368)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@balazs-szucs balazs-szucs balazs-szucs approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backend chore

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@imnotjames @balazs-szucs