frontend/src/assets/embedpdf-frame.html (1)

67-78: String replacement is fragile and could silently fail on PDFium updates.

The exact string matching ('self.postMessage({ type: "wasmError", error: message });' and 'await runner.prepare();') will break if PDFium changes whitespace, quotes, or code structure. Line 78 logs whether the patch was applied, but the code proceeds regardless.

Consider failing loudly or logging a warning when the patch didn't apply, so developers notice when PDFium updates break the shim:

Suggested improvement

         console.log('[Shim] Blob patch applied, changed=' + (patched !== parts[0]));
+        if (patched === parts[0]) {
+          console.warn('[Shim] PDFium blob source did not match expected patterns - worker shim may not function correctly');
+        }
         parts = [patched];

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@frontend/src/assets/embedpdf-frame.html` around lines 67 - 78, The current
blob-patching uses fragile exact string replaces for 'self.postMessage({ type:
"wasmError", error: message });' and 'await runner.prepare();' and then always
proceeds; change it so after performing the replacements you check whether the
content actually changed (compare patched !== parts[0]) and if it did not, fail
loudly: emit a clear console.error (or postMessage({type: "shimError", error:
"..."})) and throw an Error to halt startup so developers notice PDFium broke
the shim; keep the existing success log (console.log('[Shim] Blob patch
applied...')) when the patch succeeds and consider using more tolerant matching
(e.g., a focused regex) for 'await runner.prepare()' and the wasmError
postMessage string to reduce future brittleness.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

frontend/src/app/features/readers/pdf-reader/pdf-reader.component.ts (2)

107-108: Wrap localStorage access in try-catch for robustness.

localStorage.getItem() can throw exceptions in restricted environments (private browsing, storage disabled, or quota exceeded). Consider wrapping in a try-catch to prevent runtime errors.

♻️ Proposed fix

-    const dismissed = localStorage.getItem(this.DOC_VIEWER_DISMISSED_KEY);
-    this.isDocViewerInfoVisible = dismissed !== 'true';
+    try {
+      const dismissed = localStorage.getItem(this.DOC_VIEWER_DISMISSED_KEY);
+      this.isDocViewerInfoVisible = dismissed !== 'true';
+    } catch {
+      this.isDocViewerInfoVisible = true;
+    }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@frontend/src/app/features/readers/pdf-reader/pdf-reader.component.ts` around
lines 107 - 108, Access to localStorage.getItem(this.DOC_VIEWER_DISMISSED_KEY)
can throw in some environments, so wrap the call in a try-catch around the code
that sets this.isDocViewerInfoVisible; on error fall back to a safe default
(treat as not dismissed or use false) and optionally log the exception, ensuring
DOC_VIEWER_DISMISSED_KEY and isDocViewerInfoVisible semantics remain unchanged.

---

247-250: Consider adding error handling to localStorage.setItem.

Similar to the read operation, setItem can throw in restricted environments. For consistency and resilience, wrap in try-catch.

♻️ Proposed fix

   dismissDocViewerInfo(): void {
     this.isDocViewerInfoVisible = false;
-    localStorage.setItem(this.DOC_VIEWER_DISMISSED_KEY, 'true');
+    try {
+      localStorage.setItem(this.DOC_VIEWER_DISMISSED_KEY, 'true');
+    } catch {
+      // Ignore storage errors - banner will reappear next session
+    }
   }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@frontend/src/app/features/readers/pdf-reader/pdf-reader.component.ts` around
lines 247 - 250, The dismissDocViewerInfo method should guard the localStorage
write against exceptions: wrap the
localStorage.setItem(this.DOC_VIEWER_DISMISSED_KEY, 'true') call in a try-catch
inside dismissDocViewerInfo so the UI state change (this.isDocViewerInfoVisible
= false) still occurs even if setItem throws; in the catch, log or silently
handle the error (e.g., use console.warn or the component's logger) and avoid
rethrowing so callers are not impacted.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes