booklore-api/src/main/java/org/booklore/service/book/BookService.java (1)

75-86: Parameter StripForListView should use camelCase naming convention.

The parameter StripForListView uses PascalCase, which violates Java naming conventions for method parameters. Parameters should use camelCase: stripForListView.

This naming is inconsistent with the rest of the codebase (the controller uses stripForListView correctly at line 73).

♻️ Proposed fix for naming convention

-    public List<Book> getBookDTOs(boolean includeDescription, boolean StripForListView) {
+    public List<Book> getBookDTOs(boolean includeDescription, boolean stripForListView) {
         BookLoreUser user = authenticationService.getAuthenticatedUser();
         boolean isAdmin = user.getPermissions().isAdmin();

         List<Book> books = isAdmin
-                ? bookQueryService.getAllBooks(includeDescription, StripForListView)
+                ? bookQueryService.getAllBooks(includeDescription, stripForListView)
                 : bookQueryService.getAllBooksByLibraryIds(
                 getUserLibraryIds(user),
                 includeDescription,
-                StripForListView,
+                stripForListView,
                 user.getId()
         );

As per coding guidelines: "Use 4-space indentation in Java files and match surrounding Java style."

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@booklore-api/src/main/java/org/booklore/service/book/BookService.java` around
lines 75 - 86, Rename the method parameter StripForListView to camelCase
stripForListView in BookService.getBookDTOs and update all internal usages in
that method (calls to bookQueryService.getAllBooks and
bookQueryService.getAllBooksByLibraryIds) to use stripForListView; also update
any call sites of BookService.getBookDTOs to pass the renamed parameter name so
the signature matches callers and preserves functionality.

booklore-api/src/main/java/org/booklore/service/book/BookQueryService.java (1)

25-34: Parameter StripForListView should use camelCase naming convention.

Same naming issue as in BookService.java: the parameter StripForListView uses PascalCase instead of the Java-standard camelCase stripForListView.

The logic correctly decouples the two parameters as intended by the PR.

♻️ Proposed fix for naming convention

-    public List<Book> getAllBooks(boolean includeDescription, boolean StripForListView) {
+    public List<Book> getAllBooks(boolean includeDescription, boolean stripForListView) {
         List<BookEntity> books = bookRepository.findAllWithMetadata();
-        return mapBooksToDto(books, includeDescription, null, StripForListView);
+        return mapBooksToDto(books, includeDescription, null, stripForListView);
     }

-    public List<Book> getAllBooksByLibraryIds(Set<Long> libraryIds, boolean includeDescription, boolean StripForListView, Long userId) {
+    public List<Book> getAllBooksByLibraryIds(Set<Long> libraryIds, boolean includeDescription, boolean stripForListView, Long userId) {
         List<BookEntity> books = bookRepository.findAllWithMetadataByLibraryIds(libraryIds);
         books = contentRestrictionService.applyRestrictions(books, userId);
-        return mapBooksToDto(books, includeDescription, userId, StripForListView);
+        return mapBooksToDto(books, includeDescription, userId, stripForListView);
     }

As per coding guidelines: "Use 4-space indentation in Java files and match surrounding Java style."

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@booklore-api/src/main/java/org/booklore/service/book/BookQueryService.java`
around lines 25 - 34, Rename the parameter StripForListView to camelCase
stripForListView in the method signatures for getAllBooks and
getAllBooksByLibraryIds in BookQueryService (and update any corresponding
overloads/usages), and update the internal call to mapBooksToDto to pass
stripForListView instead of StripForListView; ensure all references (calls,
tests, and any other methods like BookService if present) are updated to the new
parameter name to keep the API consistent with Java naming conventions.

CHANGELOG.md (1)

7-14: Consider documenting the stripForListView API parameter change.

The 2.3.0 changelog does not mention the new stripForListView query parameter added to GET /api/v1/books. This is a notable API behavior change that consumers may need to know about, especially since the default behavior (stripForListView=true) differs from previous implicit behavior.

Consider adding an entry under Bug Fixes or as an API note:

* **api:** add configurable `stripForListView` parameter to book list endpoint to preserve metadata for frontend filtering

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@CHANGELOG.md` around lines 7 - 14, Add a changelog entry documenting the new
stripForListView query parameter on GET /api/v1/books introduced in 2.3.0:
update CHANGELOG.md to include a line under the appropriate section (e.g., Bug
Fixes or API Notes) that mentions the new stripForListView parameter, its
default value (stripForListView=true), and the behavioral impact (preserves
metadata for frontend filtering when set to false) so API consumers are aware of
the change; reference the endpoint GET /api/v1/books and the parameter name
stripForListView in the entry.

booklore-api/src/test/java/org/booklore/service/book/BookServiceTest.java (1)

93-104: Test updated correctly for new signature; consider adding non-admin path coverage.

The test correctly updates the stubbing and verification for the new two-boolean getBookDTOs(includeDescription, StripForListView) signature.

However, this test only covers the admin user path (getAllBooks). The non-admin path (getAllBooksByLibraryIds) also received the new StripForListView parameter but lacks test coverage. Consider adding a test case for a non-admin user to verify the parameter flows correctly through both code paths.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@booklore-api/src/test/java/org/booklore/service/book/BookServiceTest.java`
around lines 93 - 104, Add a new unit test that mirrors
getBookDTOs_adminUser_returnsBooksWithProgress but for the non-admin path: set
authenticationService.getAuthenticatedUser() to a non-admin user (or mock
isAdmin=false), stub bookQueryService.getAllBooksByLibraryIds(anySet(),
anyBoolean(), anyBoolean()) to return a List<Book> and stub
readingProgressService.fetchUserProgress(...) as needed, call
bookService.getBookDTOs(includeDescription, stripForListView) with the same
boolean args, assert the returned list and verify
bookQueryService.getAllBooksByLibraryIds(...) was invoked with the expected
library id set and the stripForListView flag (the new second boolean), and
ensure readingProgressService.fetchUserProgress(...) is also verified; use the
same helper objects (Book, UserBookProgressEntity, testUser variants) and method
names from BookServiceTest to locate where to add the test.