.github/workflows/angular-lint-threshold.yml (1)

21-23: Consider making the threshold externally configurable.

Hard-coding 725 means every threshold ratchet needs a workflow code change. Prefer repo/org variable (with fallback) to lower it progressively without workflow edits.

Suggested patch

     env:
-      LINT_THRESHOLD: 725
+      LINT_THRESHOLD: ${{ vars.FRONTEND_LINT_THRESHOLD || '725' }}

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In @.github/workflows/angular-lint-threshold.yml around lines 21 - 23, Replace
the hard-coded env value LINT_THRESHOLD: 725 with a lookup that reads a
repository/org variable or secret with a fallback to 725 so the threshold can be
changed without editing the workflow; update the env entry that sets
LINT_THRESHOLD to use a GitHub Actions expression like reading vars or secrets
(e.g., use the LINT_THRESHOLD variable name in the env block and default to 725
if not set) so the workflow references the external config rather than the
literal 725.

.github/workflows/angular-lint-threshold.yml (1)

95-96: Unnecessary working-directory on this step.

This step only uses environment variables and writes to GITHUB_STEP_SUMMARY; it doesn't access any files in ./booklore-ui. Removing the working-directory directive would simplify the step.

♻️ Suggested simplification

       - name: Enforce Quality Thresholds
-        working-directory: ./booklore-ui
         run: |

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In @.github/workflows/angular-lint-threshold.yml around lines 95 - 96, The
"Enforce Quality Thresholds" step currently sets a working-directory of
./booklore-ui even though it only uses environment variables and writes to
GITHUB_STEP_SUMMARY; remove the unnecessary working-directory key from that step
(the step block with name "Enforce Quality Thresholds") so the step runs in the
default workspace and the workflow is simplified.

.github/workflows/angular-lint-threshold.yml (2)

15-17: Consider adding a job timeout for runner safety.

A timeout-minutes on the job helps prevent hung builds from consuming runners indefinitely.

Optional patch

 jobs:
   lint-threshold:
     name: Frontend Lint Threshold Check
     runs-on: ubuntu-latest
+    timeout-minutes: 20

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In @.github/workflows/angular-lint-threshold.yml around lines 15 - 17, The
GitHub Actions job "lint-threshold" (name: Frontend Lint Threshold Check) lacks
a job timeout; add a timeout-minutes field under the job definition to prevent
hung builds from consuming runners (e.g., add timeout-minutes: 30 beneath the
lint-threshold job declaration), ensuring the workflow will cancel long-running
runs safely.

---

42-44: Using local binaries instead of npx can improve CI explicitness.

Lines 44, 50, and 77 use npx, which works correctly after npm ci installs pinned dependencies. However, directly referencing binaries from ./node_modules/.bin/ makes the reliance on installed tools more explicit and avoids any runtime package-registry lookups, even as a fallback.

Consider updating these three lines to use ./node_modules/.bin/tsc, ./node_modules/.bin/ng, etc., for clearer intent and deterministic tool invocation.

Suggested updates

-      - name: Typecheck Frontend
+      - name: Typecheck Frontend
         working-directory: ./booklore-ui
-        run: npx tsc --noEmit -p tsconfig.app.json
+        run: ./node_modules/.bin/tsc --noEmit -p tsconfig.app.json
@@
       - name: Run Frontend Build
         working-directory: ./booklore-ui
         run: |
           set +e
-          npx ng build --configuration production --progress=false 2>&1 | tee build-output.log
+          ./node_modules/.bin/ng build --configuration production --progress=false 2>&1 | tee build-output.log
           BUILD_EXIT_CODE=${PIPESTATUS[0]}
           set -e
@@
       - name: Run Frontend Linter
         working-directory: ./booklore-ui
         run: |
           # Lint output is written to JSON for threshold evaluation.
-          npx ng lint --format json --output-file lint-results.json || true
+          ./node_modules/.bin/ng lint --format json --output-file lint-results.json || true

Also applies to: 46–51, 73–77

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In @.github/workflows/angular-lint-threshold.yml around lines 42 - 44, Replace
the npx invocations with explicit local binaries to make CI tool usage
deterministic: update the "Typecheck Frontend" run command that currently uses
"npx tsc --noEmit -p tsconfig.app.json" to "./node_modules/.bin/tsc --noEmit -p
tsconfig.app.json", and likewise replace the other two npx uses (the Angular CLI
invocations using "npx ng ...") with "./node_modules/.bin/ng ..." so all three
occurrences call the binaries under ./node_modules/.bin instead of via npx.