Skip to content

fix(ui): Fixed the Angular Linter#138

Merged
balazs-szucs merged 1 commit into
grimmory-tools:developfrom
peterfortuin:fix/fixed-angular-linter
Mar 23, 2026
Merged

fix(ui): Fixed the Angular Linter#138
balazs-szucs merged 1 commit into
grimmory-tools:developfrom
peterfortuin:fix/fixed-angular-linter

Conversation

@peterfortuin

@peterfortuin peterfortuin commented Mar 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

In one of the last commits the Angular Linter got broken. This changes fixes that.

Linked Issue: #133

Changes

Updated the angular-eslint package.

Summary by CodeRabbit

  • Chores
    • Updated development tooling dependencies to latest patch versions.

Note: This release contains no user-facing changes.

@coderabbitai

coderabbitai Bot commented Mar 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

The angular-eslint devDependency version in booklore-ui/package.json was bumped from ^21.2.0 to ^21.3.1. This is a patch-level version update to the Angular ESLint tooling package.

Changes

Cohort / File(s) Summary
Dependency Version Update
booklore-ui/package.json		 Updated angular-eslint devDependency from ^21.2.0 to ^21.3.1.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A tiny tweak, a version's leap,
Angular's linter's promises to keep,
From 21.2 to 21.3 we bound,
Better linting rules all around! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning The PR claims to fix issue #133 (lint issues in frontend), but the change only updates a package version without addressing actual linting errors or warnings reported by npm run lint. Verify that updating angular-eslint from ^21.2.0 to ^21.3.1 actually resolves the lint errors in the codebase, or address the individual linting errors directly to meet issue #133 requirements.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'fix(ui): Fixed the Angular Linter' directly addresses the main change: updating angular-eslint to fix broken linter functionality.
Out of Scope Changes check ✅ Passed The package.json update is directly related to fixing the broken Angular linter mentioned in issue #133, so the change is in scope.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The PR description follows the required template with all essential sections: description of changes, linked issue reference, and details about what was updated.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@peterfortuin

peterfortuin commented Mar 23, 2026

Copy link
Copy Markdown
Contributor Author

The Linked Issues check from coderabbitai is correct. This PR doesn't solve this issue linked. But it does help.

balazs-szucs
balazs-szucs approved these changes Mar 23, 2026
View reviewed changes

@balazs-szucs balazs-szucs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@balazs-szucs balazs-szucs merged commit dd4bed6 into grimmory-tools:develop Mar 23, 2026
11 checks passed
@peterfortuin peterfortuin deleted the fix/fixed-angular-linter branch March 23, 2026 13:32
@coderabbitai coderabbitai Bot mentioned this pull request Apr 8, 2026
Closed
1 task
zachyale pushed a commit to zachyale/grimmory that referenced this pull request Apr 17, 2026
@peterfortuin @zachyale
fix(ui): Fixed the Angular Linter (grimmory-tools#138)
978348d
zachyale pushed a commit to zachyale/grimmory that referenced this pull request Apr 17, 2026
@peterfortuin @zachyale
fix(ui): Fixed the Angular Linter (grimmory-tools#138)
e14705b
zachyale pushed a commit that referenced this pull request Apr 17, 2026
@peterfortuin @zachyale
fix(ui): Fixed the Angular Linter (#138)
343256d
zachyale pushed a commit that referenced this pull request Apr 22, 2026
@peterfortuin @zachyale
fix(ui): Fixed the Angular Linter (#138)
0e61057
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@balazs-szucs balazs-szucs balazs-szucs approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@peterfortuin @balazs-szucs