refactor(entity): update fetch strategies to LAZY for improved reliability#122
Merged
Merged
Conversation
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (111)
📝 WalkthroughWalkthroughThis pull request refactors JPA lazy loading strategies and transaction boundaries across the codebase. Entity relationships are changed from eager to lazy loading with batch size hints, new repository query methods with Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant Controller
participant Service
participant SecFilter
participant UserRepo
participant BookRepo
participant DB
Client->>SecFilter: Request with JWT token
SecFilter->>UserRepo: findByIdWithDetails(userId)
UserRepo->>DB: SELECT user + settings/libraries/permissions
DB-->>UserRepo: BookLoreUserEntity with relations
UserRepo-->>SecFilter: Enriched user entity
SecFilter->>SecFilter: Create BookLoreUser DTO
SecFilter->>SecFilter: Set SecurityContext
SecFilter-->>Client: Proceed to Controller
Client->>Controller: API request (authenticated)
Controller->>Service: Business logic call
Service->>BookRepo: findByIdWithBookFiles(bookId)
BookRepo->>DB: SELECT book + bookFiles
DB-->>BookRepo: BookEntity with files
BookRepo-->>Service: Enriched book entity
Service->>Service: Process with available files
Service-->>Controller: Response DTO
Controller-->>Client: HTTP response
Estimated code review effort🎯 4 (Complex) | ⏱️ ~55 minutes Suggested reviewers
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
|
# Conflicts: # booklore-api/src/main/java/org/booklore/service/kobo/KoboEntitlementService.java
cdome
pushed a commit
to cdome/ollumi
that referenced
this pull request
Mar 25, 2026
This was referenced Mar 25, 2026
Closed
Closed
1 task
This was referenced Mar 30, 2026
This was referenced Apr 6, 2026
zachyale
pushed a commit
to zachyale/grimmory
that referenced
this pull request
Apr 17, 2026
zachyale
pushed a commit
to zachyale/grimmory
that referenced
this pull request
Apr 17, 2026
zachyale
pushed a commit
that referenced
this pull request
Apr 17, 2026
zachyale
pushed a commit
that referenced
this pull request
Apr 22, 2026
This was referenced Apr 23, 2026
Merged
7 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Linked Issue: Fixes #
Changes
See: https://www.baeldung.com/spring-open-session-in-view
First pass at fixing some of the hibernate stuff.
Main change is obvious trying to optimize the queries.
Summary by CodeRabbit
Release Notes
New Features
Performance Improvements
Bug Fixes
Chores