refactor(frontend): Migrate state to Tanstack Query + signals#117
Merged
balazs-szucs merged 2 commits intoMar 23, 2026
Merged
Conversation
Contributor
|
Important Review skippedToo many files! This PR contains 236 files, which is 86 over the limit of 150. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (236)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment Tip CodeRabbit can generate a title for your PR based on the changes.Add |
Contributor
|
From what I can it is essentially the same pattern repeating again and again. So far I can't see anything obviously wrong, and since it's the same thing repeating, I think, even with the size this PR has, it won't be "hard" to test.
Hell yeah! Any net negative of bloat/spaghetti code/boilerplate is a huge win. |
balazs-szucs
approved these changes
Mar 23, 2026
balazs-szucs
left a comment
Contributor
There was a problem hiding this comment.
Only thing I was bit worried about was auth, but seems to working just fine.
I've clicking around for the past 1 hour or so, I think everything is really good here!
Thank you again!
This was referenced Mar 24, 2026
Closed
1 task
zachyale
pushed a commit
to zachyale/grimmory
that referenced
this pull request
Apr 17, 2026
…ry-tools#117) * refactor(frontend): migrate state to TanStack Query and signals * fix(frontend): keep book cache in sync after patches
zachyale
pushed a commit
to zachyale/grimmory
that referenced
this pull request
Apr 17, 2026
…ry-tools#117) * refactor(frontend): migrate state to TanStack Query and signals * fix(frontend): keep book cache in sync after patches
zachyale
pushed a commit
that referenced
this pull request
Apr 17, 2026
* refactor(frontend): migrate state to TanStack Query and signals * fix(frontend): keep book cache in sync after patches
zachyale
pushed a commit
that referenced
this pull request
Apr 22, 2026
* refactor(frontend): migrate state to TanStack Query and signals * fix(frontend): keep book cache in sync after patches
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces the BehaviorSubject state management and manual patching technique with Tanstack Query for server data and Angular signals for local/derived states.
Key additions (frontend)
book-query-cache.ts- Single place for all adds, patches, removals and invalidations.Outcomes
takeUntil/destroy$/ngOnDestroycleanup from most componentsThis hopefully serves as a much cleaner frontend to implement some more of the bigger data wins (Pagination, server side search and filtering etc). TanStack Query has a built-in
injectInfiniteQueryfunction that automatically handles multiple batches of data, concatenating results, handling "load next" etc. At least on the frontend it should handle all this quite cleanly.Testing
Disclaimer