-
Notifications
You must be signed in to change notification settings - Fork 25
Persist Gridsync, Tahoe-LAFS, and Magic-Folder logs to disk #570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crwood
added a commit
to PrivateStorageio/PrivateStorageDesktop
that referenced
this pull request
Oct 4, 2022
The "log_maxlen" value of the "debug" section was used to tune the maximum amount of log messages that would be buffered into the log deque. With gridsync/gridsync#570, however, logs are persisted to disk (rather than buffered into memory) and the "[debug]log_maxlen" value is ignored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates Gridsync's logging system to persist log messages captured from multiple sources to the local filesystem (rather than buffering logs temporarily to memory -- where they would previously be lost between application restarts; see #564). Currently, this PR captures logs from seven different sources/streams. These are:
By default, captured logs will be written to individual files in the
logssubdirectory beneath the Gridsync configuration directory (e.g.,~/.config/gridsync/logson GNU/Linux) and can be viewed, exported, and optionally (but somewhat poorly) "filtered" using the previously-existing in-application debug log viewer (accessible via the menu -> "Help" -> "View Debug Information..."). The environment variableGRIDSYNC_LOGGING_PATHcan be used to control the location of captured logs at runtime (and will be set to.logsduring CI/test runs viatox.ini).Other aspects of logging behavior (such as the maximum log size) can also be controlled by modifying the appropriate "logging" section of
config.txt:As with all other values in
config.txt, these settings can be overridden at runtime viaGRIDSYNC_-prefixed environment variables that correspond to the appropriate section/option/value -- for exampleGRIDSYNC_LOGGING_ENABLED=falseto disable logging completed orGRIDSYNC_LOGGING_MAX_BYTES=20000000to increase the maximum log filesize from 10 MB to 20 MB.Closes #564