Disable qmessagebox logging #181
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow-up to #179, this PR changes the
gridsync.msgmodule to no longer automatically log every message that's shown to users, and adds distinct/explicitlogging.info,logging.critical,logging.errorcalls in places where logging is actually desired. Distinguishing between these two types of messages -- i.e.,QMessageBox-based messages andlogging-based messages -- allows potentially sensitive information (such as folder names, paths, etc.) to be shown in the former, while omitting it from the latter. Normal, user-facing "error" messages that are shown as a result of a user trying to add a file instead of a folder or a folder which already exists, for example, will thus no longer result in the names of those files/folders also showing up in the logs.