Skip to content

Conversation

@crwood
Copy link
Member

@crwood crwood commented Apr 5, 2019

A follow-up to #179, this PR changes the gridsync.msg module to no longer automatically log every message that's shown to users, and adds distinct/explicit logging.info, logging.critical, logging.error calls in places where logging is actually desired. Distinguishing between these two types of messages -- i.e., QMessageBox-based messages and logging-based messages -- allows potentially sensitive information (such as folder names, paths, etc.) to be shown in the former, while omitting it from the latter. Normal, user-facing "error" messages that are shown as a result of a user trying to add a file instead of a folder or a folder which already exists, for example, will thus no longer result in the names of those files/folders also showing up in the logs.

@crwood crwood merged commit c2a7fce into master Apr 5, 2019
@crwood crwood deleted the disable-qmessagebox-logging branch April 5, 2019 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants