-
Notifications
You must be signed in to change notification settings - Fork 25
168.export debug info #179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since version 4.4.0 breaks every test for some reason... :/
In case the executable is in a subdir of the homedir
As this typically contains key material (capabilities, fURLs)
To help prevent logging fURLs and capabilities
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR leverages earlier work landed previously in #174 and adds a basic user interface for loading/viewing and exporting debug logs for both Gridsync itself and its underlying Tahoe-LAFS processes (accessible via the system tray menu under "Help" -> "Export Debug Information..."). In addition to exporting logs to either a file or the system clipboard(s), this feature also provides the functionality (and which is "on" by default) to apply ad-hoc filters to the loaded/exported log buffers, stripping out most -- but probably not all -- potentially sensitive or personally-identifiable information (including known Tahoe-LAFS fURLs and capabilities, folder and grid names, magic-folder member names, and most directories/paths).
For now, users who wish to adjust or disable the in-memory log buffer(s) can do so by editing the
log_maxlenvalue in the[debug]section ofconfig.txt(with a value of0disabling the buffers completely). Friendlier user-facing controls for adjusting the behavior of this feature within the application will be added at a later date.