92.history view #116
Merged
92.history view #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since member names are currently random strings and there is no UI for setting/renaming them (yet)...
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In accordance with #92, this PR adds a per-grid "history view", currently accessible via toolbar button:
In addition, a new bottom "status panel" has been added beneath it, offering a space into which more grid-specific information can be presented (which otherwise would require the folders-view to be visible). Currently, this provides an "overall" status indicator on the left (switching between "Connecting...", "Syncing", and "Up to date"), a conditionally-present Tor icon (displayed only if connected to the grid over Tor), and a "globe" icon with grid status information in the tooltip (i.e., nodes connected, space available) as gathered from the Tahoe-LAFS WUI "welcome page". This panel can stand to be improved significantly with additional functionality and information in the future (e.g., by making the icons clickable buttons for performing various actions manually or by including additional indicators for various grid-status events) but is useful enough as a replacement for the folders-view's statusbar to warrant being included now.
In terms of per-file operations on items within the history view, currently only "open file" and "open enclosing folder" are available (via context menu and/or triple-dot-button); this can be expanded with additional actions later (e.g., for sharing individual files, restoring deleted files, browsing older versions, etc.).
Lastly, this PR includes a few misc. macOS-specific tweaks (like unifying titles and toolbars, adjusting font point-sizes, and enabling support for high-DPI "retina" displays on ".app" bundles) which, in retrospect, probably should have been included in a separate PR (but which, nevertheless, should hopefully improve visual appearance on Macs). :)