Deploy PyInstaller binaries on macOS #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crwood
added a commit
that referenced
this pull request
Sep 14, 2018
With the upstream release of PyInstaller 3.4, bootloaders should no longer need to be recompiled in order to have Gridsync run as an "agent" process on macOS. See also #112.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that PyInstaller respects Info.plist options, it can be used to deploy Gridsync binaries which properly launch as "agent"/background processes. Accordingly, this PR compiles the appropriate PyInstaller bootloaders on macOS at build time to enable this functionality, and creates the appropriate "Gridsync.app" bundle using PyInstaller (replacing "py2app"). I've kept the "py2app" setup options in place for now in the event that a "py2app" bundle is still needed/wanted (however, these may be removed at a future date).