Skip to content

using passive:true for mousemove events#2610

Merged
adumesny merged 1 commit into
gridstack:masterfrom
adumesny:master
Jan 27, 2024
Merged

using passive:true for mousemove events#2610
adumesny merged 1 commit into
gridstack:masterfrom
adumesny:master

Conversation

@adumesny

@adumesny adumesny commented Jan 27, 2024

Copy link
Copy Markdown
Member

Description

  • our app was showing errors calling e.preventDefault() because move events were marked as passive (which are more performant for smooth scrolling) so explicitly set it passive and skip the call.
  • verified the old issue of sweep selecting text field content isn't an issue anymore

Checklist

  • Created tests which fail without the change (if possible)
  • All tests passing (yarn test)
  • Extended the README / documentation, if necessary

* our app was showing errors calling e.preventDefault() because move events were marked as passive (which are more performant for smooth scrolling) so explicitly  set it passive and skip the call.
* verified the old issue of sweep selecting text field content isn't an issue anymore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant