Skip to content

Incorrect layout on grid load in one column mode#2531

Merged
adumesny merged 1 commit into
gridstack:masterfrom
adumesny:master
Nov 11, 2023
Merged

Incorrect layout on grid load in one column mode#2531
adumesny merged 1 commit into
gridstack:masterfrom
adumesny:master

Conversation

@adumesny

Copy link
Copy Markdown
Member

Description

  • fix Incorrect layout on grid load in one column mode #2527
  • turned out to be much more complicated fix than expected. cleanup some of the code while debugging through it...
  • make sure we nodeBoundFix() before widthChanged is checked
  • cacheLayout() now checks fo existing node id so loading again doesn't mess things up

Checklist

  • Created tests which fail without the change (if possible)
  • All tests passing (yarn test)
  • Extended the README / documentation, if necessary

* fix gridstack#2527
* turned out to be much more complicated fix than expected. cleanup some of the code while debugging through it...
* make sure we nodeBoundFix() before widthChanged is checked
* cacheLayout() now checks fo existing node id so loading again doesn't mess things up
@adumesny adumesny merged commit 62a1fb8 into gridstack:master Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect layout on grid load in one column mode

1 participant