no longer force rows for min-height#1912
Merged
Merged
Conversation
* fixed issue in nested.html where we had scroll bar when we shouldn't. * the old code used to set rows # to match the grid min-height (incorrectly when set to say 100% or 10rem) which we no longer do. settign an explicit heiht (in code) with min-height (in CSS) works just fine. * getCellHeight() will no longer compute using entire grid / #row, ut use the first row instead...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
getCellHeight()will no longer compute using entire grid / #row, but use the first row instead...Checklist
yarn test)