collision: fix for single grid drag out/in#1696
Merged
Merged
Conversation
* fix gridstack#1676 * simplified the code so cursor is what make items leave/enter (else we can get double shadow) * no longer need `engine.isOutside()` (we use cursor leave event) or `_isCursorOutside` (use `_temporaryRemoved`) * we also always use 'dropover'/'dropout' to track when we enter/leave to be consistent between multi grids and single one that doesn't accept widgets (instead of sing acceptWidgets flag)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
engine.isOutside()(we use cursor leave event)or
_isCursorOutside(use_temporaryRemoved)(instead of sing acceptWidgets flag)
Checklist
yarn test)