pomodoro: store datetime instead of using ticks, add nag config#694
pomodoro: store datetime instead of using ticks, add nag config#694ammgws merged 1 commit intogreshake:masterfrom GChicha:master
Conversation
|
@ghedamat Could you please confirm? |
|
Yup. I'll review and test soon and report back! |
|
I realize now that I forgot to document the new config I added to the block. |
First see if #701 works |
i3 sends SIGSTOP to the bar when it is hidden, which causes the bar to stop updating. This is done for "power savings" and is not configurable in i3 at the moment, which inconveniences users of blocks in i3status-rs that are meant to be running at all times. Luckily i3 lets us customise the signal it sends, so we can set it to something other than SIGSTOP to effectively allow non-interrupted of the bar in all situations. Fixes greshake#503, greshake#694 and possibly others.
There was a problem hiding this comment.
@GChicha this looks great, tested locally and works well. Just left a comment on an icon that you changed.
when I implemented this I was lazy and eager to get it in, so I didn't feel like doing the time math and went for the tick solution, but this is so much better :)
and was also suggested at the time by @atheriel :)
def 👍 for me!
|
I made a small change, instead of using |
|
Thanks! |
i3bar has a "power savings" feature that pauses the bar when it is hidden or obscured by a fullscreen app. However this becomes a problem for some users who use status line generators such as i3status-rust that have blocks that need to run at all times. A hacky way to prevent this from happening is to set stop_signal to a signal that won't cause the status line generator program to stop, however I do not believe that is a good solution. This PR adds an option on the i3 side to allow the user to disable this feature in the first place. This has surprised users a fair amount of time over the past few years, to show a few: greshake/i3status-rust#503 greshake/i3status-rust#694 (comment) https://faq.i3wm.org/question/4631/dont-sigstop-when-in-hide-mode.1.html i3#3242 (comment) https://www.reddit.com/r/i3wm/comments/gm6yfh/is_there_a_painless_way_to_keep_i3bar_children/
I tried to use the pomodoro block with the hide mode enabled in sway, however I notice that it didn't update while the bar is not visible. I've made some fixes to the block, changed the behavior to not update a counter, now it stores the
DateTimewhen the pomodoro starts.I still have some problems calling
swaynagori3-nagbarwhen the bar is not visible.