Skip to content
This repository was archived by the owner on Feb 8, 2018. It is now read-only.

Add route to record exchange spt#3356

Merged
chadwhitacre merged 8 commits intomasterfrom
add-route-to-record-exchange-spt
Oct 5, 2015
Merged

Add route to record exchange spt#3356
chadwhitacre merged 8 commits intomasterfrom
add-route-to-record-exchange-spt

Conversation

@rohitpaulk
Copy link
Copy Markdown
Contributor

@rohitpaulk rohitpaulk commented Apr 20, 2015

#3295

  • Add route to record-an-exchange.spt
  • Add route to MassPay calls to record-an-exchange.spt

@rohitpaulk rohitpaulk changed the title Add route to record exchange spt Add route to record exchange spt [WIP] Apr 20, 2015
@rohitpaulk
Copy link
Copy Markdown
Contributor Author

rohitpaulk commented Apr 21, 2015

screenshot from 2015-04-21 19 02 53

@rohitpaulk rohitpaulk force-pushed the add-route-to-record-exchange-spt branch from e4467b4 to efba9ac Compare April 21, 2015 16:02
@chadwhitacre
Copy link
Copy Markdown
Contributor

chadwhitacre commented Apr 21, 2015

Remind me what this helps us with? Is there a relevant ticket?

@rohitpaulk
Copy link
Copy Markdown
Contributor Author

rohitpaulk commented Apr 22, 2015

@whit537 - Sure. #3295 is the ticket.

Before we start filling the route values for previous exchanges, we should make sure that no new exchanges are created with a NULL route. As of now, record-an-exchange.spt is the only place where this happens (MassPay uses it, so that too). That's what this PR aims to fix.

@chadwhitacre
Copy link
Copy Markdown
Contributor

chadwhitacre commented Apr 22, 2015

Cool, thanks for the context.

@chadwhitacre
Copy link
Copy Markdown
Contributor

chadwhitacre commented Apr 30, 2015

Before we start filling the route values for previous exchanges

#2779

@chadwhitacre chadwhitacre mentioned this pull request Apr 30, 2015
Closed
@rohitpaulk
Copy link
Copy Markdown
Contributor Author

rohitpaulk commented May 8, 2015

This can wait, it's not blocking our move away from Balanced.

@chadwhitacre chadwhitacre added this to the Balanced Shutdown milestone Jul 30, 2015
@rohitpaulk rohitpaulk force-pushed the add-route-to-record-exchange-spt branch from efba9ac to c35e9d0 Compare October 5, 2015 16:40
@rohitpaulk rohitpaulk mentioned this pull request Oct 5, 2015
Closed
@rohitpaulk rohitpaulk force-pushed the add-route-to-record-exchange-spt branch from c35e9d0 to b6de74e Compare October 5, 2015 18:07
@rohitpaulk rohitpaulk force-pushed the add-route-to-record-exchange-spt branch from b6de74e to 12fe413 Compare October 5, 2015 18:25
@rohitpaulk rohitpaulk mentioned this pull request Oct 5, 2015
Merged
@rohitpaulk rohitpaulk changed the title Add route to record exchange spt [WIP] Add route to record exchange spt Oct 5, 2015
chadwhitacre added a commit that referenced this pull request Oct 5, 2015
@chadwhitacre
Merge pull request #3356 from gratipay/add-route-to-record-exchange-spt
dce2503 
Add route to record exchange spt
@chadwhitacre chadwhitacre merged commit dce2503 into master Oct 5, 2015
@chadwhitacre chadwhitacre deleted the add-route-to-record-exchange-spt branch October 5, 2015 20:29
@chadwhitacre
Copy link
Copy Markdown
Contributor

chadwhitacre commented Oct 5, 2015

!m @rohitpaulk

Yay! 💃

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

Review

Projects

None yet

Milestone

Balanced Shutdown

Development

Successfully merging this pull request may close these issues.

2 participants

@rohitpaulk @chadwhitacre