-
Notifications
You must be signed in to change notification settings - Fork 722
Settings are not being set/loaded consistently (Attempt to consolidate multiple issues) #826
Copy link
Copy link
Closed
Description
This issue pertains to the following package(s):
- GraphQL Playground - Electron App
- GraphQL Playground HTML
- GraphQL Playground
- GraphQL Playground Express Middleware
- GraphQL Playground Hapi Middleware
- GraphQL Playground Koa Middleware
- GraphQL Playground Lambda Middleware
NOTE: I've only tried with Express Middleware, but since this issue is an attempt to consolidate different other issues, I am keeping the ticks from what I've seen elsewhere.
What version of graphql-playground(-electron/-middleware) are you experiencing the issue(s) on?
graphql-playground-middleware-express@1.7.4
What is the expected behavior?
- Setting a different default for
request.credentialsserver side should take effect. - Setting a different default for any setting server side should reflect the new default value in the Settings tab
- Setting a different default for only a subset of the settings should still be picking up the remaining default from the hardcoded values.
What is the actual behavior?
- No effect whatsoever.
- For any other setting other than
request.credentials, setting a default seems to work, but the value shown in the settings tab won't reflect what's been set server side (e.g. set theme to light server side; it will take effect, but the settings tab will still show dark) - If I set new defaults for two of the settings, other settings get no default at all, e.g. the font family won't be correct, thus messing the whole style up
What steps may we take to reproduce the behavior?
- Build a server app with express, use
graphql-playground-middleware-express@1.7.4 - Instantiate server-side default for the settings as per above scenarios.
Related issues
- request.credentials configuration is ignored #791
- Settings don't update from the client if any setting is set from the server #796
- Cookies are not being sent in Playground Express #748
- No visible cursor #790
There may be more.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels