-
Notifications
You must be signed in to change notification settings - Fork 722
Settings don't update from the client if any setting is set from the server #796
Copy link
Copy link
Closed
Description
This issue pertains to the following package(s):
- GraphQL Playground - Electron App
- GraphQL Playground HTML
- GraphQL Playground
- GraphQL Playground Express Middleware
- GraphQL Playground Hapi Middleware
- GraphQL Playground Koa Middleware
- GraphQL Playground Lambda Middleware
What version of graphql-playground(-electron/-middleware) are you experiencing the issue(s) on?
graphql-playground-html@1.6.0
graphql-playground-middleware-express@1.7.2
Example
import playground from 'graphql-playground-middleware-express';
app.get(
'/playground',
playground({
endpoint: '/graphql',
settings: { 'editor.fontSize': 16 }
})
);
Playground properly uses that font size but still shows setting as 14 (the default) under settings. If I try to change the font size, theme, etc. from the client it doesn't take effect.
The only exception is request.credentials is actually able to be changed from the client. Likely related to this bug #791 as it can't be set by the server.
If I don't set any settings from the server
import playground from 'graphql-playground-middleware-express';
app.get(
'/playground',
playground({
endpoint: '/graphql'
})
);
then everything works fine.
I'm not sure if this is a bug or intended. But it would be ideal to be able to set default settings from the server but allow users to update those from the client and have them persist across sessions.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels