fix: do not copy over stack from error cause#4784
Merged
Merged
Conversation
|
@Malien is attempting to deploy a commit to the The GraphQL Foundation Team on Vercel. A member of the Team first needs to authorize it. |
my edits to graphql#4485 incorrectly passes originalError instead of cause for the stack-less cause test
Contributor
|
@Malien fantastic! Thanks for the original PR, and thanks for these corrections. I pushed a few cosmetic test changes, looks ok to you? |
Contributor
Author
|
@yaacovCR Yeah. Looks great. |
yaacovCR
added a commit
that referenced
this pull request
Jun 2, 2026
## v17.0.0-rc.0 (2026-06-02) #### New Feature 🚀 * [#4670](#4670) feat(v17): Implement tracing channels ([@logaretm](https://github.com/logaretm)) #### Bug Fix 🐞 * [#4761](#4761) fix: DeferStreamDirectiveOnRootField forbids fragments on abstract types ([@robrichard](https://github.com/robrichard)) * [#4762](#4762) fix: DeferStreamDirectiveOnValidOperations fragment tracking ([@robrichard](https://github.com/robrichard)) * [#4784](#4784) fix: do not copy over stack from error cause ([@Malien](https://github.com/Malien)) #### Docs 📝 * [#4781](#4781) docs: improve deprecation information regarding originalError and cause ([@yaacovCR](https://github.com/yaacovCR)) #### Committers: 4 * Abdelrahman Awad([@logaretm](https://github.com/logaretm)) * Rob Richard([@robrichard](https://github.com/robrichard)) * Yaacov Rydzinski ([@yaacovCR](https://github.com/yaacovCR)) * Yaroslav Petryk([@Malien](https://github.com/Malien))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've authored #4485 long time ago. Since that PR sat there for a while, I didn't get a chance to amend the design to not copy over the stack from the
cause.Copying over the stack will just double up the same stack trace twice in the reporting tooling / console logs.