Enable Flow typings on errors tests + Fix typing for Error constructor#1582
Merged
Conversation
IvanGoncharov
commented
Nov 21, 2018
| constructor( | ||
| message: string, | ||
| nodes?: $ReadOnlyArray<ASTNode> | ASTNode | void, | ||
| nodes?: $ReadOnlyArray<ASTNode> | ASTNode | void | null, |
Member
Author
There was a problem hiding this comment.
All other arguments support null so there is no reason why nodes accepts undefined but not the null.
yaacovCR
added a commit
to yaacovCR/graphql-js
that referenced
this pull request
Jun 1, 2026
This test originally used a plain object without a stack. PR graphql#1582 changed it to new Error('original') while enabling Flow typing, which meant the test no longer exercised the no-stack fallback path. This PR deletes the generated stack before constructing GraphQLError so the test can synthetically cover the intended branch while still passing type check.
yaacovCR
added a commit
that referenced
this pull request
Jun 1, 2026
This test originally used a plain object without a stack. PR #1582 changed it to new Error('original') while enabling Flow typing, which meant the test no longer exercised the no-stack fallback path. This PR deletes the generated stack before constructing GraphQLError so the test can synthetically cover the intended branch while still passing type check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.