Skip to content

fix (graphiql-react): Text selection highlight does not match selection#4232

Merged
trevor-scheer merged 4 commits into
graphql:mainfrom
simmerer:multiline-text-highlight-exceeds-selection
May 15, 2026
Merged

fix (graphiql-react): Text selection highlight does not match selection#4232
trevor-scheer merged 4 commits into
graphql:mainfrom
simmerer:multiline-text-highlight-exceeds-selection

Conversation

@simmerer

@simmerer simmerer commented May 7, 2026

Copy link
Copy Markdown
Contributor

Addresses #4094

Before:

Screenshot 2026-05-07 at 4 12 12 PM

After:

Screenshot 2026-05-07 at 4 13 30 PM

@changeset-bot

changeset-bot Bot commented May 7, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 1fd1298

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphiql/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@simmerer simmerer changed the title fix: Text selection highlight does not match selection fix (graphiql-react): Text selection highlight does not match selection May 11, 2026
@trevor-scheer

Copy link
Copy Markdown
Contributor

Just confirmed the issue and tested your fix, lgtm. Thanks!

@trevor-scheer trevor-scheer merged commit 3934e4a into graphql:main May 15, 2026
13 checks passed
trevor-scheer pushed a commit that referenced this pull request May 15, 2026
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## monaco-graphql@1.8.0

### Minor Changes

- [#4264](#4264)
[`227f5ba`](227f5ba)
Thanks [@trevor-scheer](https://github.com/trevor-scheer)! - Add
`./monaco-editor` to the `exports` map.

`monaco-graphql/monaco-editor` re-exports `monaco-editor` with only the
graphql and json languages, skipping the css, html, and typescript
contributions that the default `monaco-editor` entry point bundles.
Consumers can use it to share a single `monaco-editor` instance with
`monaco-graphql` (for `editor`, `Uri`, `KeyMod`, `KeyCode`, `languages`,
etc.) without paying for those extras. Until now you had to reach for
the unstable `monaco-graphql/esm/monaco-editor` path, which only
resolves under legacy `node10`-style module resolution.

The legacy `monaco-graphql/esm/monaco-editor` path still works via the
existing `./*` wildcard, so this change is purely additive.

The `monaco-graphql/esm/*` import pattern is now considered deprecated.
It will continue to work throughout the `1.x` line, but the wildcard
`exports` entry that enables it is planned for removal in the next major
version. New code should prefer the canonical paths:
`monaco-graphql/monaco-editor`, `monaco-graphql/initializeMode`,
`monaco-graphql/graphql.worker`, and `monaco-graphql/lite`.

## codemirror-graphql@2.2.6

### Patch Changes

- [#4274](#4274)
[`d23f3b1`](d23f3b1)
Thanks [@trevor-scheer](https://github.com/trevor-scheer)! - Bump
TypeScript emit target from `es5` to `es6`.

The published JavaScript now uses ES6 syntax (`const`, arrow functions,
native destructuring) instead of down-leveled ES5. In practice this is
consumed via a bundler in every real-world setup (and paired with
CodeMirror 5, which already requires an ES6 runtime), so this changes
the intermediate emit but not what consumers end up shipping. Code that
loads the published `.js` directly in a strictly ES5-only environment
(e.g. IE11 without transpilation) is no longer supported. CodeMirror 5
itself does not support that configuration.

## @graphiql/react@0.37.5

### Patch Changes

- [#4232](#4232)
[`3934e4a`](3934e4a)
Thanks [@simmerer](https://github.com/simmerer)! - Bugfix for multiline
selection highlight styling: disabling Monaco's `roundedSelection`
option prevents selection highlight from appearing to extend beyond
actual text selection. See issue
[#4094](#4094).

- Updated dependencies
\[[`227f5ba`](227f5ba)]:
    -   monaco-graphql@1.8.0

## vscode-graphql@0.13.5

### Patch Changes

- [#4267](#4267)
[`e4f5148`](e4f5148)
Thanks [@trevor-scheer](https://github.com/trevor-scheer)! - Burning
patch version due to previous release failure.

## vscode-graphql-execution@0.3.5

### Patch Changes

- [#4267](#4267)
[`e4f5148`](e4f5148)
Thanks [@trevor-scheer](https://github.com/trevor-scheer)! - Burning
patch version due to previous release failure.

## vscode-graphql-syntax@1.3.11

### Patch Changes

- [#4267](#4267)
[`e4f5148`](e4f5148)
Thanks [@trevor-scheer](https://github.com/trevor-scheer)! - Burning
patch version due to previous release failure.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants