Skip to content

Add yarn dedupe check to CI#4223

Merged
dimaMachina merged 1 commit into
mainfrom
trevor/dedupe
May 1, 2026
Merged

Add yarn dedupe check to CI#4223
dimaMachina merged 1 commit into
mainfrom
trevor/dedupe

Conversation

@trevor-scheer

Copy link
Copy Markdown
Contributor

#4222 encountered surprising errors after running yarn dedupe due to inconsistent versions of prettier in the lockfile. This check ensures we're using the same versions of dependencies across the repo whenever possible.

@trevor-scheer trevor-scheer requested a review from dimaMachina May 1, 2026 19:20
@changeset-bot

changeset-bot Bot commented May 1, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 8b7e36a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actions Bot commented May 1, 2026

Copy link
Copy Markdown
Contributor

The latest changes of this PR are not available as canary, since there are no linked changesets for this PR.

@dimaMachina dimaMachina merged commit b771e7a into main May 1, 2026
13 checks passed
@dimaMachina dimaMachina deleted the trevor/dedupe branch May 1, 2026 19:33
trevor-scheer added a commit that referenced this pull request May 7, 2026
## Summary

`ci:version` runs `yarn changeset version` but never `yarn install`, so
the Version Packages PR ends up with a stale `yarn.lock`. CI's `Yarn
Dedupe Check` (added in #4223) catches this on `yarn install
--immutable`.

Adding `yarn install --no-immutable` after the version step matches the
recipe in other yarn-berry monorepos — e.g.
[`medusajs/medusa`](https://github.com/medusajs/medusa/blob/ea2165be7d3963f016cfed31f47da4c9bd24e285/package.json#L164)
and
[`toeverything/blocksuite`](https://github.com/toeverything/blocksuite/blob/5cb5cb68471ca692f3c162258f0087cb22fcb82d/package.json#L23).
Neither `changesets/action` nor `changesets` docs mention it.

### Why now

#4223 only just added the dedupe check. Before that, stale lockfiles
landed quietly on `main`; the next contributor's local `yarn install`
regenerated them, leaving a stray `yarn.lock` diff in their PR.
Reviewers skip large lockfile diffs.

## Test plan

- [ ] Next Version Packages PR includes a `yarn.lock` diff and passes
`Yarn Dedupe Check`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants