Skip to content

Upgrade to Yarn 4#3975

Merged
dimaMachina merged 17 commits into
mainfrom
yarn-4
Jun 1, 2025
Merged

Upgrade to Yarn 4#3975
dimaMachina merged 17 commits into
mainfrom
yarn-4

Conversation

@benjie

@benjie benjie commented May 31, 2025

Copy link
Copy Markdown
Member

Yarn 1.x entered maintenance mode in January 2020; time to upgrade.

This PR does minimal changes, it's based on the setup I use in the Graphile Crystal monorepo which I've been running without issues for years.

Depends on:

closes #2185 #3306 #3303

@changeset-bot

changeset-bot Bot commented May 31, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 5332c31

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
graphql-language-service-server Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benjie benjie force-pushed the yarn-4 branch 3 times, most recently from d28fc30 to f45aede Compare May 31, 2025 16:51
Base automatically changed from sort-packages to main May 31, 2025 20:11
@acao

acao commented May 31, 2025

Copy link
Copy Markdown
Member

@benjie the LSP integration test suite is failing because it appears that the fetch mocking is failing, and the monaco build test is something you can ask @dimaMachina about, but it looks like it's now asserting the wrong line after a vite upgrade I think?

@codecov

codecov Bot commented Jun 1, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.97%. Comparing base (917b505) to head (5332c31).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3975      +/-   ##
==========================================
+ Coverage   63.94%   63.97%   +0.03%     
==========================================
  Files          35       35              
  Lines        3087     3087              
  Branches      950      948       -2     
==========================================
+ Hits         1974     1975       +1     
+ Misses       1108     1107       -1     
  Partials        5        5              
Files with missing lines Coverage Δ
...raphql-language-service-server/src/GraphQLCache.ts 78.59% <ø> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Jun 1, 2025

Copy link
Copy Markdown
Contributor

The latest changes of this PR are available as canary in npm (based on the declared changesets):

graphql-language-service-cli@3.5.1-canary-dd0a9847.0
graphql-language-service-server@2.14.8-canary-dd0a9847.0

// `--no-colors` flag
const lines = stdout.replaceAll(ANSI_COLOR_REGEX, '').split('\n');
// expect(lines[0]).toBe('$ vite build');
// expect(lines[1]).toMatch(' building for production...');

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is no longer output.

Comment thread packages/graphql-language-service-server/src/__tests__/__utils__/MockProject.ts Outdated
Comment thread packages/monaco-graphql/test/monaco-editor.test.ts Outdated
@dimaMachina dimaMachina merged commit 4375aa7 into main Jun 1, 2025
2 of 3 checks passed
@dimaMachina dimaMachina deleted the yarn-4 branch June 1, 2025 12:34
@acao acao mentioned this pull request Jun 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move to yarn 3 + pnp, pnpm or latest npm?

3 participants