Skip to content

pnpm + turbo (no cjs + no ts project refs)#3306

Closed
acao wants to merge 49 commits into
mainfrom
pnpm-turbo-no-cjs
Closed

pnpm + turbo (no cjs + no ts project refs)#3306
acao wants to merge 49 commits into
mainfrom
pnpm-turbo-no-cjs

Conversation

@acao

@acao acao commented Jun 29, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

this one is for real, not just for reference!

  • drop cjs
  • drop typescript project references
  • add turbo
  • replace yarn with pnpm
  • add build and dev packages to every workspace
  • prettier
  • drop build-bundles
  • vscode compile -> build
  • proper exports for codemirror-graphql
  • eslint
  • cypress failures - something with the minor bundling tweaks is causing codemirror-graphql jsonParser exceptions to not be caught as linter errors??
  • webpack dev server - build works but dev server 404s
  • changsets upgrade
  • typedoc

Notes

  • we may need to leave project references in place just so that we can resolve projects for the latest typedoc. I don't think there is a way around this for typescript. we don't have to use typescript project references for the build of course
  • running pnpm dev alongside cypress open or jest, a common workflow for me when working across packages, seems to crash my PC
  • for some reason, the @graphiql/react tsconfig.json was configured to compile __test__ directory. this was not needed for jest-ts but seemed to make eslint happy, but i found a way to resolve this

What can hopefully come in later PRs:

  • migrate graphiql webpack bundler to vite
  • monaco language bundling fix
  • replace tsc usage with bob, tsup, etc
  • typescript upgrade
  • replace jest with vitest
  • import react properly
  • etc

it's a more lean version of #3303 with some agreed upon tooling changes

@changeset-bot

changeset-bot Bot commented Jun 29, 2023 •
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: e5e3a4b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR 
Some errors occurred when validating the changesets config:
The package or glob expression "example-*" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@acao acao force-pushed the pnpm-turbo-no-cjs branch 3 times, most recently from 4fd5433 to 7d8967a Compare June 29, 2023 19:34
@acao acao force-pushed the pnpm-turbo-no-cjs branch from 7d8967a to b83005d Compare June 29, 2023 19:36
@acao acao force-pushed the pnpm-turbo-no-cjs branch 2 times, most recently from 982e740 to d6f7a71 Compare June 29, 2023 20:07
@acao acao force-pushed the pnpm-turbo-no-cjs branch from d6f7a71 to 34809cc Compare June 29, 2023 20:08
@github-actions

github-actions Bot commented Jun 29, 2023

Copy link
Copy Markdown
Contributor

The latest changes of this PR are not available as canary, since there are no linked changesets for this PR.

@acao acao force-pushed the pnpm-turbo-no-cjs branch from 4bd70da to e288d27 Compare June 29, 2023 22:02
@acao acao changed the title pnpm turbo no cjs pnpm + turbo + no cjs + no ts project refs Jun 29, 2023
@acao acao force-pushed the pnpm-turbo-no-cjs branch from 407a532 to 39afb66 Compare June 29, 2023 22:50
@acao acao force-pushed the pnpm-turbo-no-cjs branch 2 times, most recently from 1d9eea6 to ce46877 Compare July 1, 2023 10:31
@acao acao force-pushed the pnpm-turbo-no-cjs branch from ce46877 to 920483a Compare July 1, 2023 10:32
@acao acao force-pushed the pnpm-turbo-no-cjs branch from 3a57e13 to 0c4af1f Compare July 1, 2023 10:54
@acao

acao commented Jul 1, 2023 •
edited
Loading

Copy link
Copy Markdown
Member Author

yay! cypress now runs using something closer to the reccomended config. we had to move cypress back into root devDependencies as per the cypress reccomendation

@acao acao force-pushed the pnpm-turbo-no-cjs branch from 8fbd8ab to 06619a2 Compare July 1, 2023 11:05
@acao

acao commented Jul 2, 2023

Copy link
Copy Markdown
Member Author

@B2o5T I will include instructions soon on how to try this out and start giving very specifically scoped feedback and/or contribution if you are interested. It has somehow introduced a few detectable regressions, see notes. The vscode extension tests will take precedence as they are of a greater concern

@acao acao removed the lsp-rewrite label Jul 2, 2023
@acao acao mentioned this pull request Jul 5, 2023
Merged
Noodleontour
Noodleontour approved these changes Dec 8, 2023
View reviewed changes

@Noodleontour Noodleontour left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool

@dimaMachina dimaMachina mentioned this pull request Jun 1, 2025
Merged
@dimaMachina

dimaMachina commented Jun 1, 2025

Copy link
Copy Markdown
Collaborator

closed by #3975

@dimaMachina dimaMachina closed this Jun 1, 2025
@dimaMachina dimaMachina deleted the pnpm-turbo-no-cjs branch June 1, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dimaMachina dimaMachina dimaMachina left review comments
+2 more reviewers
@Noodleontour Noodleontour Noodleontour approved these changes
@anowardear062-svg anowardear062-svg anowardear062-svg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

do not merge tooling

Projects

Modern Monorepo Tooling Sprint
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@acao @dimaMachina @Noodleontour @anowardear062-svg