Skip to content

Rollback #3883#3900

Merged
dimaMachina merged 1 commit into
mainfrom
dimaMachina-patch-1
Apr 30, 2025
Merged

Rollback #3883#3900
dimaMachina merged 1 commit into
mainfrom
dimaMachina-patch-1

Conversation

@dimaMachina

Copy link
Copy Markdown
Collaborator

#3883 breaks release action, with the following errors https://github.com/graphql/graphiql/actions/runs/14684686099/job/41329136728

This PR rolls back the previous behaviour to unblock the release workflow. Let's figure out later what's a proper fix

@changeset-bot

changeset-bot Bot commented Apr 30, 2025

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 4947cb0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dimaMachina dimaMachina changed the title Rollbak #3883 Rollback #3883 Apr 30, 2025
@dimaMachina dimaMachina merged commit a6e8dd3 into main Apr 30, 2025
@dimaMachina dimaMachina deleted the dimaMachina-patch-1 branch April 30, 2025 22:02
@github-actions

Copy link
Copy Markdown
Contributor

The latest changes of this PR are not available as canary, since there are no linked changesets for this PR.

dimaMachina pushed a commit that referenced this pull request Apr 17, 2026
## Summary

- Fix VS Code extension publishing to OpenVSX (and VS Code Marketplace)
which has been broken since the Yarn 4 upgrade
- Add `--no-dependencies` to all `vsce` and `ovsx` commands, bypassing
the incompatible `yarn list --prod --json` call that Yarn 4 removed
- Update `vscode-graphql-syntax`'s stale `ovsx` version and broken
publish command

This attempts to fix #4178, will validate and close after a successful
publish.

## Some additional context

`@vscode/vsce` [only
supports](https://github.com/microsoft/vscode-vsce?tab=readme-ov-file#requirements)
Yarn `>=1 <2`. When packaging an extension, it shells out to `yarn list
--prod --json` to discover runtime dependencies. This doesn't exist in
Yarn Berry/v4.

The graphql repo [upgraded to Yarn
4](4375aa7a) in June 2025,
which seems to have broken all extension packaging. The root `release`
script wraps `wsrun release` in `|| true`
([`package.json:55`](https://github.com/graphql/graphiql/blob/main/package.json#L55)),
so these failures are silently swallowed and the workflow reports
success. We also don't have logs from GH actions that long ago, so we're
flying blind as far as past runs go.

There was a prior attempt to fix publishing in
[#3883](#3883) (which removed
`|| true`), but the underlying packaging failure caused the release
workflow to break, leading to a rollback in
[#3900](#3900). There are a
[couple errors still
visible](https://github.com/graphql/graphiql/actions/runs/14684686099/job/41329136728)
that align with the yarn failures I suspect.

## Why `--no-dependencies`?

`--no-dependencies` tells `vsce`/`ovsx` to skip dependency discovery
entirely. This is safe because all three extensions bundle their deps:

- **`vscode-graphql`**: esbuild bundles all deps into `out/extension.js`
([`esbuild.js:14`](https://github.com/graphql/graphiql/blob/main/packages/vscode-graphql/esbuild.js#L14):
`bundle: true`)
- **`vscode-graphql-execution`**: same esbuild bundling
([`esbuild.js:10`](https://github.com/graphql/graphiql/blob/main/packages/vscode-graphql-execution/esbuild.js#L10):
`bundle: true`)
- **`vscode-graphql-syntax`**: ships only grammar JSON files, no runtime
code or dependencies

This is the same approach recommended in
[microsoft/vscode-vsce#421](microsoft/vscode-vsce#421)
for projects using non-supported package managers.

## Changes

**All three extensions** (`vscode-graphql`, `vscode-graphql-execution`,
`vscode-graphql-syntax`):
- Added `--no-dependencies` to `vsce:package`, `vsce:publish`, and
`open-vsx:publish` scripts

**`vscode-graphql-syntax` only:**
- Updated `ovsx` from `^0.3.0` to `0.8.3` (matching the other two
extensions)
- Fixed `open-vsx:publish` command — was `ovsx publish --yarn -i . --pat
$OVSX_PAT` which incorrectly passes `.` (a directory) to `--packagePath`
(expects `.vsix` files)

**`vscode-graphql` and `vscode-graphql-execution`:**
- Simplified `open-vsx:publish` — removed the `$(ls -1 *.vsix | sort -V
| tail -n 1)` glob since `ovsx publish` (with no positional arg)
packages from the working directory directly

## Test Plan

1. From `packages/vscode-graphql`, run `npx @vscode/vsce package --yarn
--no-dependencies` — should produce a `.vsix` file successfully
2. Repeat for `packages/vscode-graphql-execution` (run `yarn compile`
first)
3. Repeat for `packages/vscode-graphql-syntax`
4. Verify the full release flow works in CI once merged (the `|| true`
in the root release script means a failure won't block other publishes,
but check the workflow logs to confirm extension publishing succeeds)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant