This repository was archived by the owner on Aug 23, 2023. It is now read-only.
improve performance of hashing seriesbytag with fnv#1436
Merged
robert-milan merged 9 commits intomasterfrom Aug 21, 2019
Merged
improve performance of hashing seriesbytag with fnv#1436robert-milan merged 9 commits intomasterfrom
robert-milan merged 9 commits intomasterfrom
Conversation
replay
reviewed
Aug 17, 2019
copy test files from schema
1e88217 to
9203c66
Compare
fix error in MetricDefinition method
…ing-reusable keeping hash type reusable
replay
reviewed
Aug 20, 2019
replay
approved these changes
Aug 21, 2019
Contributor
replay
left a comment
There was a problem hiding this comment.
LGTM, please check my commits before merging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the poor performance of
BySeriesWithTagsFnv. It moves the code fromfnvinto the method itself which reduces our allocations to 1 and speeds things up quite a bit.It also adds the tests back into
schema, and creates a new test specifically for the old and new methods used to obtain the partition withfnvin this PR.These benchmarks were not performed in a suitable environment for benchmarking, but I think the difference is large enough to not warrant it.
Benchcmp
Original
New