This repository was archived by the owner on Aug 23, 2023. It is now read-only.
keeping hash type reusable#1439
Merged
replay merged 3 commits intoimprove-serieswithtags-fnv-hashingfrom Aug 20, 2019
Merged
Conversation
fix error in MetricDefinition method
Contributor
|
I added some more tests for |
robert-milan
approved these changes
Aug 20, 2019
Contributor
robert-milan
left a comment
There was a problem hiding this comment.
with the changes LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what do you think about this? it performs almost as good as your branch, but it keeps the hash type reusable, instead of copying all its code into the functions.