Global: migrating from go-kit/kit/log to the slimmer go-kit/log#4164
Global: migrating from go-kit/kit/log to the slimmer go-kit/log#4164dannykopping wants to merge 1 commit intografana:mainfrom
Conversation
Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
|
Hi! This issue has been automatically marked as stale because it has not had any We use a stalebot among other tools to help manage the state of issues in this project. Stalebots are also emotionless and cruel and can close issues which are still very relevant. If this issue is important to you, please add a comment to keep it open. More importantly, please add a thumbs-up to the original issue entry. We regularly sort for closed issues which have a We may also:
We are doing our best to respond, organize, and prioritize all issues but it can be a challenging task, |
What this PR does / why we need it:
This PR aims to align Loki with Prometheus (see prometheus/prometheus#8927) in its use of
go-kit's logger.go-kit/kit/logwas split out intogo-kit/log, and that's all we use ofgo-kitostensibly.Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
This bit me recently when trying to understand why debug logs were printed when I'd explicitly set
-log.level=info. It turns out that if a log message is written from within the vendored Prometheus code, it uses the newergo-kit/log, so this coercion mysterious fails even though the type seems correct. That was a fun one to debug 🙃Checklist