Skip to content

Global: migrating from go-kit/kit/log to the slimmer go-kit/log#4164

Closed
dannykopping wants to merge 1 commit intografana:mainfrom
dannykopping:dannykopping/go-kit
Closed

Global: migrating from go-kit/kit/log to the slimmer go-kit/log#4164
dannykopping wants to merge 1 commit intografana:mainfrom
dannykopping:dannykopping/go-kit

Conversation

@dannykopping
Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
This PR aims to align Loki with Prometheus (see prometheus/prometheus#8927) in its use of go-kit's logger. go-kit/kit/log was split out into go-kit/log, and that's all we use of go-kit ostensibly.

Which issue(s) this PR fixes:
N/A

Special notes for your reviewer:
This bit me recently when trying to understand why debug logs were printed when I'd explicitly set -log.level=info. It turns out that if a log message is written from within the vendored Prometheus code, it uses the newer go-kit/log, so this coercion mysterious fails even though the type seems correct. That was a fun one to debug 🙃

Checklist

  • Documentation added
  • Tests updated

Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
@stale
Copy link
Copy Markdown

stale bot commented Sep 19, 2021

Hi! This issue has been automatically marked as stale because it has not had any
activity in the past 30 days.

We use a stalebot among other tools to help manage the state of issues in this project.
A stalebot can be very useful in closing issues in a number of cases; the most common
is closing issues or PRs where the original reporter has not responded.

Stalebots are also emotionless and cruel and can close issues which are still very relevant.

If this issue is important to you, please add a comment to keep it open. More importantly, please add a thumbs-up to the original issue entry.

We regularly sort for closed issues which have a stale label sorted by thumbs up.

We may also:

  • Mark issues as revivable if we think it's a valid issue but isn't something we are likely
    to prioritize in the future (the issue will still remain closed).
  • Add a keepalive label to silence the stalebot if the issue is very common/popular/important.

We are doing our best to respond, organize, and prioritize all issues but it can be a challenging task,
our sincere apologies if you find yourself at the mercy of the stalebot.

@stale stale bot added the stale A stale issue or PR that will automatically be closed. label Sep 19, 2021
@stale stale bot closed this Oct 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XL stale A stale issue or PR that will automatically be closed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant