All committers have signed the CLA.

Hi @MagnusRef,

thanks for your PR. It adds consistency to the Helm chart.

However, this is a potential breaking change.
Currently, users can set memcachedExporter.image.repository=internal.registry/memcached and define their own registry. With your change, this would break, because it would result in
image: docker.io/internal.registry/memcached

There are two possible solutions:

1. Accept the breaking change and document it.

2. Add a condition: if repository does not contain a ., then prefix with registry.

   image: {{ if not (contains "." .repository) }}{{ .registry }}/{{ end }}{{ .repository }}:{{ .tag }}
   

3. Do nothing.

Before we discuss this internally, we need an activity signal from your side in the form of a PR rebase.

Hello @jkroepke

Yeah, this change is a little too small to warrant a breaking change IMO, so option two seems like a good solution.

However, would it make sense to standardize this logic across all of the other .image instances to keep things consistent?

However, would it make sense to standardize this logic across all of the other .image instances to keep things consistent?

Should be great, but please start after

• fix(helm): Respect global registry in sidecar image (#18246) #19347
• fix(helm): standardize global image registry to match other Grafana charts #19246
• feat(helm): add image registry value for memcached and memcached-exporter #16511

has been merged.

Closing in favor of #19246